Skip to content

chore: refactor / fix tests #21439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 16, 2024
Merged

chore: refactor / fix tests #21439

merged 5 commits into from
Nov 16, 2024

Conversation

@dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Nov 15, 2024 •
edited
Loading

  • Create a hack/ directory and move assorted tests/scripts there
  • Fix a broken test that checks for unused media files
  • Delete unused media files
  • Update labeler/codeowner

@dvdksn dvdksn requested a review from a team November 15, 2024 15:29
@github-actions github-actions bot added area/hub Issue affects Docker Hub area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/admin Relates to Docker Admin hugo Updates related to hugo area/config area/tests area/guides labels Nov 15, 2024
@netlify
Copy link

netlify bot commented Nov 15, 2024 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 6551157
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/673769e71a328600084c9059
😎 Deploy Preview https://deploy-preview-21439--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the area/release Relates to CI or deployment label Nov 15, 2024
sarahsanders-docker
sarahsanders-docker approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@sarahsanders-docker sarahsanders-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dvdksn dvdksn merged commit 1dd7371 into docker:main Nov 16, 2024
14 checks passed
@dvdksn dvdksn deleted the test-refactor branch November 16, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@craig-osterhout craig-osterhout Awaiting requested review from craig-osterhout craig-osterhout is a code owner

@aevesdocker aevesdocker Awaiting requested review from aevesdocker aevesdocker is a code owner

1 more reviewer

@sarahsanders-docker sarahsanders-docker sarahsanders-docker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/admin Relates to Docker Admin area/config area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/guides area/hub Issue affects Docker Hub area/release Relates to CI or deployment area/tests hugo Updates related to hugo status/review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dvdksn @sarahsanders-docker