Skip to content

Conversation

@vvoland
Copy link
Contributor

@vvoland vvoland commented Dec 2, 2024

Description

Engine: 92a83937d0280dcbea92099b01e01aa4251c1777
CLI: 0a1f8e414bc166215c393cdc775a455987cef5a5

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added the area/engine Issue affects Docker engine/daemon label Dec 2, 2024
@netlify
Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit eaa2ac4
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/675714cb7811ae00072b64c9
😎 Deploy Preview https://deploy-preview-21546--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some quick comments around linting errors; I opened a PR to address some of them;

@thaJeztah
Copy link
Member

@vvoland #21589 was merged; can you try a rebase and addressing the review comments to see if CI is happier? (I'll try to give it a more thorough review later as well)

@vvoland
Copy link
Contributor Author

vvoland commented Dec 9, 2024

Rebased and updated with newly merged changes

@vvoland vvoland marked this pull request as ready for review December 9, 2024 14:49
Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

Signed-off-by: Paweł Gronowski <[email protected]>
Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@dvdksn dvdksn merged commit f9b0855 into docker:main Dec 9, 2024
14 checks passed
@thaJeztah
Copy link
Member

Thanks so much, @vvoland for this! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/engine Issue affects Docker engine/daemon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants