vale: add some acronyms and allowed words #21589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
3 tasks
thaJeztah
commented
Dec 9, 2024
ZFS; https://en.wikipedia.org/wiki/ZFS Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
update_vale
branch
from
b9b443f to
605665f
Compare
dvdksn
reviewed
Dec 9, 2024
Contributor
dvdksn
left a comment
dvdksn
left a comment
There was a problem hiding this comment.
LGTM except DAD - I don't think we should add that as an acronym exception. (the Acronyms.yml file only lists acronyms that we allow not to be expanded before use, but I think DAD should be expanded. If it is expanded, the vale rule won't fire. The issue in pawel's PR was that the acronym was expanded without capitalization, I left a comment on that PR: https://github.com/docker/docs/pull/21546/files#r1875991549)
Used for (e.g.) "userland proxy" Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
update_vale
branch
from
605665f to
caf5a0e
Compare
Member
Author
|
Ah! I was wondering that indeed; makes sense. I dropped that commit 👍 |
dvdksn
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vale: add ZFS as acronym
ZFS; https://en.wikipedia.org/wiki/ZFS
vale: add userland to accept list
Used for (e.g.) "userland proxy"
Description
Related issues or tickets
Reviews