ENGDOCS-2332 #21639
ENGDOCS-2332 #21639
Conversation
github-actions
bot
added
the
area/compose
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| - `command`: Specifies the command to run once the container starts. This attribute is required, and you can choose to use either the shell form or the exec form. | ||
| - `user`: The user to run the command. If not set, the command is run with the same user as the main service command. | ||
| - `privileged`: Lets the command run with privileged access. | ||
| - `working_dir`: The working directory in which to run the command. If not set, it is run in the same working directory as the main service command. | ||
| - `environment`: Sets the environment variables to run the command. While the command inherits the environment variables defined for the service’s main command, this section lets you add new variables or override existing ones. |
There was a problem hiding this comment.
just a consistency question. this bulleted lists uses command: description format, while the one before it uses command, description format. not sure if this was intentional and if so if there is a reason to use one over the other?
There was a problem hiding this comment.
True! There was no rhyme or reason to it. Good spot - will do a consistency follow up!
sarahsanders-docker
left a comment
sarahsanders-docker
left a comment
There was a problem hiding this comment.
overall looks good! I left one nit/consistency question that I was curious about
| kubefwd | ||
| kubelet | ||
| lookup | ||
| label_file |
There was a problem hiding this comment.
Adding this to the vocabulary is not the right way to fix this lint error
If this is to disable the sentence case check, you should disable that rule instead.
There was a problem hiding this comment.
it wasn't for the sentence case thing, was being flagged as a 'are you sure you meant..' one.
There was a problem hiding this comment.
OK, but there are a lot more headings that are flagged for the same thing in this and the other compose file docs. You could disable spellcheck, or better, wrap the options in code spans, to bypass this rule. Adding all of these params to the vocabulary doesn't seem like a good solution
There was a problem hiding this comment.
Ok good to know, will resolve in the follow-up as well
<!--Delete sections as needed --> ## Description Looks larger than it is: - - A follow-up to comments on #21639 - Deals with hotjar issue https://docker.slack.com/archives/C04BMTUC41E/p1734970724382829 - Vale freshness ## Related issues or tickets <!-- Related issues, pull requests, or Jira tickets --> ## Reviews <!-- Notes for reviewers here --> <!-- List applicable reviews (optionally @tag reviewers) --> - [ ] Technical review - [ ] Editorial review - [ ] Product review --------- Co-authored-by: Sarah Sanders <[email protected]>
3 participants
Description
Adds new attributes to the spec from the recent 2.32.0 release
Related issues or tickets
Reviews