quick fix: add tags to build code sample #22016
Conversation
sarahsanders-docker
requested review from
aevesdocker,
crazy-max and
thaJeztah
github-actions
bot
added
the
area/build
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@crazy-max PTAL (is this a bug in the action?) |
| platforms: ${{ matrix.platform }} | ||
| labels: ${{ steps.meta.outputs.labels }} | ||
| outputs: type=image,"name=${{ env.DOCKERHUB_REPO }},${{ env.GHCR_REPO }}",push-by-digest=true,name-canonical=true,push=true | ||
| outputs: type=image,"name=${{ env.DOCKERHUB_REPO }}:latest,${{ env.GHCR_REPO }}:latest",push-by-digest=true,name-canonical=true,push=true |
There was a problem hiding this comment.
No we should not set a tag here, only repo name as we are pushing by digest with push-by-digest=true and merging these to create tags in merge job. If that fails that means something odd happens on this runner. I will ask to the user having this issue.
There was a problem hiding this comment.
I indeed tried adding tags at this step but this leads to strange results as then randomly one of the platform images will have e.g. the latest tag or a semver tag like 0.3.9, which then makes it impossible to use those tags on the other architectures.
There was a problem hiding this comment.
Added the link to the workflow and the full workflow file to the issue.
sarahsanders-docker
changed the title
4 participants
Description
Error: buildx failed with: ERROR: tag is needed when pushing to registrywhen using our code sample in https://docs.docker.com/build/ci/github-actions/multi-platform/#distribute-build-across-multiple-runners:latesttags to code sample, this is the most general approach and not version specific, which will work for most users who are just trying things out using our code samplesRelated issues or tickets
Reviews