Skip to content

quick fix: add tags to build code sample #22016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

quick fix: add tags to build code sample #22016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/manuals/build/ci/github-actions/multi-platform.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ jobs:
with:
platforms: ${{ matrix.platform }}
labels: ${{ steps.meta.outputs.labels }}
outputs: type=image,"name=${{ env.DOCKERHUB_REPO }},${{ env.GHCR_REPO }}",push-by-digest=true,name-canonical=true,push=true
outputs: type=image,"name=${{ env.DOCKERHUB_REPO }}:latest,${{ env.GHCR_REPO }}:latest",push-by-digest=true,name-canonical=true,push=true
Copy link
Member

@crazy-max crazy-max Feb 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we should not set a tag here, only repo name as we are pushing by digest with push-by-digest=true and merging these to create tags in merge job. If that fails that means something odd happens on this runner. I will ask to the user having this issue.

Copy link

@KonradHoeffner KonradHoeffner Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I indeed tried adding tags at this step but this leads to strange results as then randomly one of the platform images will have e.g. the latest tag or a semver tag like 0.3.9, which then makes it impossible to use those tags on the other architectures.

Copy link

@KonradHoeffner KonradHoeffner Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the link to the workflow and the full workflow file to the issue.


- name: Export digest
run: |
Expand Down