Skip to content

Conversation

@sarahsanders-docker
Copy link
Contributor

@sarahsanders-docker sarahsanders-docker commented Mar 7, 2025

Description

Related issues or tickets

Reviews

  • Technical review
  • Editorial review

@sarahsanders-docker sarahsanders-docker requested review from a team and crazy-max March 7, 2025 14:15
@github-actions github-actions bot added area/build Relates to Dockerfiles or docker build command hugo Updates related to hugo labels Mar 7, 2025
@netlify
Copy link

netlify bot commented Mar 7, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 623d2b9
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/67cb11ea74eca500081bd64e
😎 Deploy Preview https://deploy-preview-22190--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

usha-mandya
usha-mandya previously approved these changes Mar 7, 2025
Copy link
Member

@usha-mandya usha-mandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @sarahsanders-docker

@crazy-max
Copy link
Member

Looks a bit off with the icon no? https://deploy-preview-22190--docsdocker.netlify.app/build/buildkit/dockerfile-release-notes/#1140-labs

image

@sarahsanders-docker
Copy link
Contributor Author

sarahsanders-docker commented Mar 7, 2025

@crazy-max decided to just change to a callout and back to the includes file, I guess the summary bar doesn't look great on all screen sizes if we add more words to each line.

@crazy-max
Copy link
Member

@crazy-max decided to just change to a callout and back to the includes file, I guess the summary bar doesn't look great on all screen sizes if we add more words to each line.

Yes looks good like this thanks!

crazy-max
crazy-max previously approved these changes Mar 7, 2025
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sarahsanders-docker sarahsanders-docker merged commit 1b3ec1b into docker:main Mar 7, 2025
14 checks passed
sarahsanders-docker added a commit that referenced this pull request Mar 7, 2025
## Description
- follow up from #22190 to cleanup
includes that use an embedded shortcode (this breaks rendering in hugo
w/ current versions)

## Related issues or tickets
#22190

## Reviews
- [ ] Technical review
- [ ] Editorial review
- [ ] Product review
mdelapenya added a commit to mdelapenya/docker-docs that referenced this pull request Mar 11, 2025
* main: (42 commits)
  Update image source for kafbat
  Add missing release note to Docker Desktop release notes (docker#22218)
  Update build-summary.md
  feedback link fix: (docker#22212)
  some clarification on additional_contexts (docker#22204)
  Update windows-install.md (docker#22184)
  sso: add callout to certificate instructions (docker#22193)
  chore: cleanup includes w/ embedded shortcodes (docker#22191)
  fix: rendering issue w/ experimental labs include (docker#22190)
  billing: improve docs for manual payment retries (docker#22181)
  build: fix intro of distributed build section (docker#22189)
  dd-cli-cicd-fix (docker#22187)
  Update release note for 4.39 (docker#22188)
  Change directory after pulling a sample Docker application (docker#22179)
  Merge pull request docker#22117 from aevesdocker/ENGDOCS-2451
  fix: troubleshooting toc fix (docker#22166)
  Add security section to 4.39.0 release notes (docker#22178)
  Merge pull request docker#22175 from aevesdocker/ENGDOCS-2470
  Merge pull request docker#22160 from sarahsanders-docker/tcc-minutes
  hub: add troubleshooting (docker#22157)
  ...
@sarahsanders-docker sarahsanders-docker deleted the rendering-issue-buildkit branch April 21, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Relates to Dockerfiles or docker build command hugo Updates related to hugo status/review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants