-
Notifications
You must be signed in to change notification settings - Fork 8.1k
fix: rendering issue w/ experimental labs include #22190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rendering issue w/ experimental labs include #22190
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
usha-mandya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @sarahsanders-docker
|
Looks a bit off with the icon no? https://deploy-preview-22190--docsdocker.netlify.app/build/buildkit/dockerfile-release-notes/#1140-labs |
|
@crazy-max decided to just change to a callout and back to the includes file, I guess the summary bar doesn't look great on all screen sizes if we add more words to each line. |
Yes looks good like this thanks! |
crazy-max
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* main: (42 commits) Update image source for kafbat Add missing release note to Docker Desktop release notes (docker#22218) Update build-summary.md feedback link fix: (docker#22212) some clarification on additional_contexts (docker#22204) Update windows-install.md (docker#22184) sso: add callout to certificate instructions (docker#22193) chore: cleanup includes w/ embedded shortcodes (docker#22191) fix: rendering issue w/ experimental labs include (docker#22190) billing: improve docs for manual payment retries (docker#22181) build: fix intro of distributed build section (docker#22189) dd-cli-cicd-fix (docker#22187) Update release note for 4.39 (docker#22188) Change directory after pulling a sample Docker application (docker#22179) Merge pull request docker#22117 from aevesdocker/ENGDOCS-2451 fix: troubleshooting toc fix (docker#22166) Add security section to 4.39.0 release notes (docker#22178) Merge pull request docker#22175 from aevesdocker/ENGDOCS-2470 Merge pull request docker#22160 from sarahsanders-docker/tcc-minutes hub: add troubleshooting (docker#22157) ...

Description
Related issues or tickets
Reviews