Skip to content

Conversation

@tanure
Copy link
Contributor

@tanure tanure commented Mar 18, 2025

Description

I did some improvements to the quickstart.md file, adding images and improve some descriptions to be albe to helo learners to find the references mentioned in the file.

Related issues or tickets

No related issues or ticket.

Reviews

  • Technical review
  • Editorial review
  • Product review

@tanure tanure requested a review from craig-osterhout as a code owner March 18, 2025 10:46
@github-actions github-actions bot added the area/scout Relates to Docker Scout label Mar 18, 2025
@netlify
Copy link

netlify bot commented Mar 18, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit d3c85ea
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/68093217fccecd0008e2e3d7
😎 Deploy Preview https://deploy-preview-22272--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tanure
Copy link
Contributor Author

tanure commented Mar 25, 2025

Hi @craig-osterhout ,

I hope you're doing well. Is there anything else I should do on this PR to be considered?

Best Regards,
Albert Tanure

@craig-osterhout
Copy link
Contributor

Thanks @tanure. Nothing further is needed at this moment. If you want a head start on the feedback, please check the comments added by the linters.

Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tanure. This topic definitely needed a refresh. I left some nits from our style guide and some other suggestions.

@tanure
Copy link
Contributor Author

tanure commented Apr 14, 2025

Hi @craig-osterhout ,

Thank you very much for your comments.

@craig-osterhout craig-osterhout self-requested a review April 14, 2025 15:21
Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. A couple small typos slipped in. After fixing those, it's good to go.

tanure and others added 2 commits April 23, 2025 20:31
Solving typos issues

Co-authored-by: Craig Osterhout <[email protected]>
Solving typos issues

Co-authored-by: Craig Osterhout <[email protected]>
Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM.

@craig-osterhout craig-osterhout merged commit 7b9471d into docker:main Apr 23, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/scout Relates to Docker Scout status/review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants