Skip to content

fix: only render admin icon for keyword in summary bar #22325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

fix: only render admin icon for keyword in summary bar #22325

merged 1 commit into from
Mar 28, 2025

Conversation

@sarahsanders-docker
Copy link
Contributor

@sarahsanders-docker sarahsanders-docker commented Mar 27, 2025

Description

  • adds an if statement that will only render the admin icon if the keyword "Administrators" is present
  • gives us flexibility to use this line for other strings/use cases, without rendering the admin icon

Related issues or tickets

Reviews

@aevesdocker to fix the summary bar for models PR

  • Technical review
  • Editorial review
  • Product review

@sarahsanders-docker sarahsanders-docker requested review from a team and aevesdocker March 27, 2025 17:41
@github-actions github-actions bot added the hugo Updates related to hugo label Mar 27, 2025
@sarahsanders-docker sarahsanders-docker mentioned this pull request Mar 27, 2025
Merged
3 tasks
@netlify
Copy link

netlify bot commented Mar 27, 2025 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit aeb3a2b
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/67e58de117d71b000801f8bb
😎 Deploy Preview https://deploy-preview-22325--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

craig-osterhout
craig-osterhout approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aevesdocker
Copy link
Contributor

aevesdocker commented Mar 28, 2025

Thank you @sarahsanders-docker!

@sarahsanders-docker sarahsanders-docker merged commit 5092d97 into docker:main Mar 28, 2025
14 checks passed
@sarahsanders-docker sarahsanders-docker deleted the summary-bar-fix-field branch April 21, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@craig-osterhout craig-osterhout craig-osterhout approved these changes

@aevesdocker aevesdocker Awaiting requested review from aevesdocker

Assignees

No one assigned

Labels

hugo Updates related to hugo status/review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sarahsanders-docker @aevesdocker @craig-osterhout