Added Configure GitHub Actions step to the Python guide #22676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for docsdocker failed. Why did it fail? →
|
rw4lll
approved these changes
May 28, 2025
Contributor
rw4lll
left a comment
rw4lll
left a comment
There was a problem hiding this comment.
Looks good to me. I think it's ready to be merged.
craig-osterhout
requested changes
Jun 4, 2025
Contributor
craig-osterhout
left a comment
craig-osterhout
left a comment
There was a problem hiding this comment.
Thanks @igor-alexandrov.
Only a couple small issues I think it's good to go.
- At the end of
containerize.md, the next steps section needs to be updated to reflect the different ordering of the topics. It should say ci/cd is next rather than develop. - At the end of
develop.md, the next steps section needs to be updated to reflect the different ordering of the topics. It should say test deployment is next rather than ci/cd.
3 tasks
Contributor
Author
|
@craig-osterhout thank you! I updated both parts of the guide. |
estebanx64
added a commit
to estebanx64/docker-docs
that referenced
this pull request
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced "Configure CI/CD" step of the Python guide with "Configure GitHub Actions" step to have it similar structure as the Rails guide.
Related issues or tickets
#22114
Reviews