-
Notifications
You must be signed in to change notification settings - Fork 8.1k
model-cli reference docs #22681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
model-cli reference docs #22681
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ed76536 to
6378aeb
Compare
ArthurFlag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌟
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
|
Rebased to fix conflict after #22687 was merged |
|
vale seems to fail: https://github.com/docker/docs/actions/runs/15295918829/job/43024912108?pr=22681 But don't know why if someone wants to take a look. |
|
@crazy-max we're good now 🚀 |
|
|
||
|
|
||
| <!---MARKER_GEN_END--> | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change? This is vendored and should not be edited manually 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-save in my editor trimmed stuff when I was testing the vale fix... Should I revert this? (do we care since it's autogen?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(do we care since it's autogen?)
If you mean autogen on ci that's not the case, it's only done through make vendor or hugo mod vendor so should not be edited whatsoever. But I see there is nothing atm to validate that vendor dir is pristine. We should look at this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, i will create a ticket. I also reverted the formatting.
## Description Adds model-cli reference docs. ## Related issues or tickets * docker/model-cli#62 * docker/model-cli#69 ## Reviews <!-- Notes for reviewers here --> <!-- List applicable reviews (optionally @tag reviewers) --> - [ ] Technical review - [ ] Editorial review - [ ] Product review --------- Signed-off-by: CrazyMax <[email protected]> Co-authored-by: ArthurFlag <[email protected]>

Description
Adds model-cli reference docs.
Related issues or tickets
Reviews