Skip to content

Conversation

@aevesdocker
Copy link
Contributor

Description

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@netlify
Copy link

netlify bot commented Jun 5, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 98f2930
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/68418b6edded9200083ce2f8
😎 Deploy Preview https://deploy-preview-22788--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

| `allowBetaFeatures` | | If `value` is set to `true`, beta features are enabled. | |
| `enableDockerAI` | | If `allowBetaFeatures` is true, setting `enableDockerAI` to `true` enables [Docker AI (Ask Gordon)](/manuals/ai/gordon/_index.md) by default. You can independently control this setting from the `allowBetaFeatures` setting. | |
| `enableInference` | | If `allowBetaFeatures` is true, setting `enableInference` to `true` enables [Docker Model Runner](/manuals/ai/model-runner/_index.md) by default. You can independently control this setting from the `allowBetaFeatures` setting. | |
|         `enableInferenceTCP` | | Enable host-side TCP support. This setting requires Docker Model Runner setting to be enabled first. | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|         `enableInferenceTCP` | | Enable host-side TCP support. This setting requires Docker Model Runner setting to be enabled first. | |
| `enableInferenceTCP` | | Enable host-side TCP support. This setting requires Docker Model Runner setting to be enabled first. | |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but this setting depends on the 'enableInference' setting, so I've nested it, like we do with other settings above

Copy link
Contributor

@ArthurFlag ArthurFlag Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok, that's a little weird IMHO because that's not semantic nesting, that's just visual. Ideally we should have a sub table, or use a different notation like prop1.prop2, or use nested LI tags.

That probably should be reworked, especially if we want AI to understand it too :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, noted, will address in a follow-up.

@aevesdocker aevesdocker requested a review from ArthurFlag June 5, 2025 12:30
@aevesdocker aevesdocker enabled auto-merge June 5, 2025 12:35
@aevesdocker aevesdocker merged commit 659c547 into docker:main Jun 5, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants