Skip to content

Commit d5807de

Browse files
committed
tests: Skip tests failing on darwin
TestConfigServerExclusiveRootPools and TestConfigClientExclusiveRootPools are failing on darwin with the same error message as on Windows: > Unable to verify certificate 1: x509: certificate signed by unknown authority The `(*Certificate).Verify()` method from `crypto/x509` special-case windows, darwin and ios GOOS to use a OS-specific verification process. This process seems to consider root CAs as invalid for some unknown reasons. This should be further investigated. Signed-off-by: Albin Kerouanton <[email protected]>
1 parent 8c00429 commit d5807de

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

tlsconfig/config_test.go

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -199,10 +199,9 @@ func TestConfigServerTLSClientCASet(t *testing.T) {
199199
// Exclusive root pools determines whether the CA pool will be a union of the system
200200
// certificate pool and custom certs, or an exclusive or of the custom certs and system pool
201201
func TestConfigServerExclusiveRootPools(t *testing.T) {
202-
if runtime.GOOS == "windows" {
203-
// FIXME TestConfigServerExclusiveRootPools is failing on windows:
204-
// config_test.go:244: Unable to verify certificate 1: x509: certificate signed by unknown authority
205-
t.Skip("FIXME: failing on Windows")
202+
if runtime.GOOS == "windows" || runtime.GOOS == "darwin" {
203+
// FIXME: see https://github.com/docker/go-connections/issues/105.
204+
t.Skip("FIXME: failing on Windows and darwin")
206205
}
207206
key, cert := getCertAndKey()
208207
ca := getMultiCert()
@@ -564,10 +563,9 @@ func TestConfigClientTLSNotSetWithInvalidPassphrase(t *testing.T) {
564563
// Exclusive root pools determines whether the CA pool will be a union of the system
565564
// certificate pool and custom certs, or an exclusive or of the custom certs and system pool
566565
func TestConfigClientExclusiveRootPools(t *testing.T) {
567-
if runtime.GOOS == "windows" {
568-
// FIXME TestConfigClientExclusiveRootPools is failing on windows:
569-
// config_test.go:597: Unable to verify certificate 1: x509: certificate signed by unknown authority
570-
t.Skip("FIXME: failing on Windows")
566+
if runtime.GOOS == "windows" || runtime.GOOS == "darwin" {
567+
// FIXME: see https://github.com/docker/go-connections/issues/105.
568+
t.Skip("FIXME: failing on Windows and darwin")
571569
}
572570
ca := getMultiCert()
573571

0 commit comments

Comments
 (0)