Skip to content

Commit d545e91

Browse files
author
colinmcneil
committed
Fix catalog config with query
1 parent 9638607 commit d545e91

File tree

3 files changed

+16
-12
lines changed

3 files changed

+16
-12
lines changed

src/extension/ui/src/components/tile/ConfigEditor.tsx

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ const ConfigEditor = ({ catalogItem, client }: { catalogItem: CatalogItemRichene
4646
// Reset local config when the existing config changes
4747
useEffect(() => {
4848
if (!configSchema) return;
49-
if (localConfig) return;
5049
setLocalConfig(flattenedConfig);
5150
}, [flattenedConfig]);
5251

@@ -87,14 +86,21 @@ const ConfigEditor = ({ catalogItem, client }: { catalogItem: CatalogItemRichene
8786
{isSaving ? (
8887
<CircularProgress size={24} />
8988
) : (
90-
<IconButton onClick={() => setLocalConfig({
91-
...localConfig,
92-
[key]: flattenedConfig[key]
93-
})}
94-
disabled={isSaving}
95-
>
96-
<CloseOutlined sx={{ color: 'error.main' }} />
97-
</IconButton>
89+
<Stack direction="row" spacing={2}>
90+
<IconButton onClick={() => updateExistingConfig(catalogItem.name, localConfig)}
91+
disabled={isSaving}
92+
>
93+
<CheckOutlined sx={{ color: 'success.main' }} />
94+
</IconButton>
95+
<IconButton onClick={() => setLocalConfig({
96+
...localConfig,
97+
[key]: flattenedConfig[key]
98+
})}
99+
disabled={isSaving}
100+
>
101+
<CloseOutlined sx={{ color: 'error.main' }} />
102+
</IconButton>
103+
</Stack>
98104
)}
99105
</Stack>}
100106
</Stack>

src/extension/ui/src/components/tile/Modal.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,6 @@ const ConfigurationModal = ({
5858
const { registerCatalogItem, unregisterCatalogItem } = useCatalogOperations(client)
5959
const { configLoading } = useConfig(client)
6060

61-
console.log('catalogItem', catalogItem)
62-
6361
useEffect(() => {
6462
setLocalSecrets(catalogItem.secrets.reduce((acc, secret) => {
6563
acc[secret.name] = secret.assigned ? ASSIGNED_SECRET_PLACEHOLDER : '';

src/extension/ui/src/hooks/useCatalog.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export function useCatalog(client: v1.DockerDesktopClient) {
4545
missingConfig: unConfigured,
4646
missingSecrets: missingASecret,
4747
registered: !!registryItems?.[item.name],
48-
canRegister: !registryItems?.[item.name] && !missingASecret && !unConfigured,
48+
canRegister: !missingASecret && !unConfigured,
4949
name: item.name,
5050
};
5151
return enrichedItem;

0 commit comments

Comments
 (0)