Set auth only for docker images

dgageot · dgageot · commit d3aea7209804 · 2025-07-08T11:42:35.000+02:00
Signed-off-by: David Gageot &lt;david.gageot@docker.com&gt;
diff --git a/cmd/docker-mcp/internal/docker/images.go b/cmd/docker-mcp/internal/docker/images.go
@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"io"
 	"runtime"
+	"strings"
 	"sync"
 
 	cerrdefs "github.com/containerd/errdefs"
@@ -69,8 +70,9 @@ func (c *dockerClient) pullImage(ctx context.Context, imageName string, registry
 		}
 	}
 
-	pullOptions := image.PullOptions{
-		RegistryAuth: registryAuthFn(),
+	var pullOptions image.PullOptions
+	if strings.HasPrefix(ref.Name(), "docker.io/") {
+		pullOptions.RegistryAuth = registryAuthFn()
 	}
 
 	response, err := c.apiClient().ImagePull(ctx, imageName, pullOptions)

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@ import (`
`5`	`5`	`"fmt"`
`6`	`6`	`"io"`
`7`	`7`	`"runtime"`
	`8`	`+ "strings"`
`8`	`9`	`"sync"`
`9`	`10`
`10`	`11`	`cerrdefs "github.com/containerd/errdefs"`
`@@ -69,8 +70,9 @@ func (c *dockerClient) pullImage(ctx context.Context, imageName string, registry`
`69`	`70`	`}`
`70`	`71`	`}`
`71`	`72`
`72`		`- pullOptions := image.PullOptions{`
`73`		`- RegistryAuth: registryAuthFn(),`
	`73`	`+ var pullOptions image.PullOptions`
	`74`	`+ if strings.HasPrefix(ref.Name(), "docker.io/") {`
	`75`	`+ pullOptions.RegistryAuth = registryAuthFn()`
`74`	`76`	`}`
`75`	`77`
`76`	`78`	`response, err := c.apiClient().ImagePull(ctx, imageName, pullOptions)`