Merge pull request #366 from doringeman/debug-log-ascend-mounts

fix(standalone): use StatusPrinter in tryGetBindAscendMounts

Author: doringeman

cmd/cli/commands/utils.go

@@ -58,6 +58,11 @@ func (cp *commandPrinter) Println(args ...any) {
 	cp.cmd.Println(args...)
 }
 
+// PrintErrf implements StatusPrinter.PrintErrf by delegating to cobra.Command.PrintErrf
+func (cp *commandPrinter) PrintErrf(format string, args ...any) {
+	cp.cmd.PrintErrf(format, args...)
+}
+
 // Write implements StatusPrinter.Write by delegating to cobra.Command's output writer
 func (cp *commandPrinter) Write(p []byte) (n int, err error) {
 	return cp.cmd.OutOrStdout().Write(p)

cmd/cli/pkg/standalone/containers.go

@@ -233,7 +233,7 @@ func isRootless(ctx context.Context, dockerClient *client.Client) bool {
 }
 
 // Check whether the host Ascend driver path exists. If so, create the corresponding mount configuration.
-func tryGetBindAscendMounts() []mount.Mount {
+func tryGetBindAscendMounts(printer StatusPrinter) []mount.Mount {
 	hostPaths := []string{
 		"/usr/local/dcmi",
 		"/usr/local/bin/npu-smi",
@@ -245,7 +245,7 @@ func tryGetBindAscendMounts() []mount.Mount {
 	for _, hostPath := range hostPaths {
 		matches, err := filepath.Glob(hostPath)
 		if err != nil {
-			fmt.Errorf("Error checking glob pattern for %s: %v", hostPath, err)
+			printer.PrintErrf("Error checking glob pattern for %s: %v\n", hostPath, err)
 			continue
 		}
 
@@ -258,7 +258,9 @@ func tryGetBindAscendMounts() []mount.Mount {
 			}
 			newMounts = append(newMounts, newMount)
 		} else {
-			fmt.Printf("  [NOT FOUND] Ascend driver path does not exist, skipping: %s\n", hostPath)
+			if os.Getenv("DEBUG") == "1" {
+				printer.Printf("[NOT FOUND] Ascend driver path does not exist, skipping: %s\n", hostPath)
+			}
 		}
 	}
 
@@ -309,7 +311,7 @@ func CreateControllerContainer(ctx context.Context, dockerClient *client.Client,
 			Name: "always",
 		},
 	}
-	ascendMounts := tryGetBindAscendMounts()
+	ascendMounts := tryGetBindAscendMounts(printer)
 	if len(ascendMounts) > 0 {
 		hostConfig.Mounts = append(hostConfig.Mounts, ascendMounts...)
 	}

cmd/cli/pkg/standalone/status.go

@@ -2,10 +2,12 @@ package standalone
 
 // StatusPrinter is the interface used to print status updates.
 type StatusPrinter interface {
-	// Printf should perform formatted printing.
+	// Printf should perform formatted printing to stdout.
 	Printf(format string, args ...any)
-	// Println should perform line-based printing.
+	// Println should perform line-based printing to stdout.
 	Println(args ...any)
+	// PrintErrf should perform formatted printing to stderr.
+	PrintErrf(format string, args ...any)
 	// Write implements io.Writer for stream-based output.
 	Write(p []byte) (n int, err error)
 	// GetFdInfo returns the file descriptor and terminal status for the output.
@@ -21,6 +23,9 @@ func (*noopPrinter) Printf(format string, args ...any) {}
 // Println implements StatusPrinter.Println.
 func (*noopPrinter) Println(args ...any) {}
 
+// PrintErrf implements StatusPrinter.PrintErrf.
+func (*noopPrinter) PrintErrf(format string, args ...any) {}
+
 // Write implements StatusPrinter.Write.
 func (*noopPrinter) Write(p []byte) (n int, err error) {
 	return len(p), nil