Skip to content

Commit d370bbd

Browse files
committed
Move passthrough model name to constant and clarify error message.
Signed-off-by: Jacob Howard <jacob.howard@docker.com>
1 parent 74c9839 commit d370bbd

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

pkg/inference/scheduling/loader.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@ const (
2525
// defaultRunnerIdleTimeout is the default maximum amount of time that a
2626
// runner can sit idle (i.e. without any requests) before being terminated.
2727
defaultRunnerIdleTimeout = 5 * time.Minute
28+
// passthroughModelName is the model name used for runners associated with
29+
// passthrough backends.
30+
passthroughModelName = "passthrough"
2831
)
2932

3033
var (

pkg/inference/scheduling/scheduler.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ func (s *Scheduler) handleOpenAIInference(w http.ResponseWriter, r *http.Request
321321
// backends, we assume they have external model management.
322322
if backendMode == inference.BackendModeCompletion || backendMode == inference.BackendModeEmbedding {
323323
if request.Model == "" {
324-
http.Error(w, "invalid request, model is required", http.StatusBadRequest)
324+
http.Error(w, `invalid request - "model" is required`, http.StatusBadRequest)
325325
return
326326
}
327327
model, err := s.modelManager.GetModel(request.Model)
@@ -343,7 +343,7 @@ func (s *Scheduler) handleOpenAIInference(w http.ResponseWriter, r *http.Request
343343
// runners (one for each model used by a passthrough backend).
344344
runnerModel := request.Model
345345
if backendMode == inference.BackendModePassthrough {
346-
runnerModel = "passthrough"
346+
runnerModel = passthroughModelName
347347
}
348348

349349
// Request a runner to execute the request and defer its release.

0 commit comments

Comments
 (0)