Merge pull request #423 from doringeman/nit-vllm-warning

refactor(distribution): change unsupported format warning message

Author: ericcurtin

pkg/distribution/distribution/client.go

@@ -509,8 +509,8 @@ func checkCompat(image types.ModelArtifact, log *logrus.Entry, reference string,
 			utils.SanitizeForLog(reference))
 	} else if !slices.Contains(GetSupportedFormats(), config.Format) {
 		// Write warning but continue with pull
-		log.Warnf("vLLM backend currently only implemented for x86_64 Nvidia platforms")
-		if err := progress.WriteWarning(progressWriter, ErrUnsupportedFormat.Error()); err != nil {
+		log.Warnln(warnUnsupportedFormat)
+		if err := progress.WriteWarning(progressWriter, warnUnsupportedFormat); err != nil {
 			log.Warnf("Failed to write warning message: %v", err)
 		}
 		// Don't return an error - allow the pull to continue

pkg/distribution/distribution/client_test.go

@@ -477,7 +477,7 @@ func TestClientPullModel(t *testing.T) {
 			if !strings.Contains(progressOutput, `"type":"warning"`) {
 				t.Fatalf("Expected warning message on non-Linux platforms, got output: %s", progressOutput)
 			}
-			if !strings.Contains(progressOutput, "safetensors") {
+			if !strings.Contains(progressOutput, warnUnsupportedFormat) {
 				t.Fatalf("Expected warning about safetensors format, got output: %s", progressOutput)
 			}
 		}

pkg/distribution/distribution/errors.go

@@ -16,6 +16,7 @@ var (
 		"client supports only models of type %q and older - try upgrading",
 		types.MediaTypeModelConfigV01,
 	))
-	ErrUnsupportedFormat = errors.New("vLLM backend currently only implemented for x86_64 Nvidia platforms")
-	ErrConflict          = errors.New("resource conflict")
+	ErrConflict = errors.New("resource conflict")
 )
+
+const warnUnsupportedFormat = "vLLM backend currently only implemented for x86_64 NVIDIA platforms"