Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

Commit d97b9ba

Browse files
authored
Merge pull request #132 from docker/fix_watermark
Fix MUI license issue
2 parents e44e78a + d770a22 commit d97b9ba

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

.github/workflows/build-scan-push.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@ jobs:
124124
build-args: |
125125
BUGSNAG_RELEASE_STAGE=production
126126
BUGSNAG_APP_VERSION=${{ github.event.release.tag_name }}
127+
VALID_SECRET_CACHE=1
127128
secrets: |
128129
"BUGSNAG_API_KEY=${{ secrets.BUGSNAG_API_KEY }}"
129130
"REACT_APP_MUI_LICENSE_KEY=${{ secrets.REACT_APP_MUI_LICENSE_KEY }}"

Dockerfile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ RUN --mount=type=cache,target=/usr/src/app/.npm \
2020
npm ci
2121
# install
2222
COPY ui /ui
23+
# avoid reusing cached layers from another build without secrets provided, cf https://docs.docker.com/build/cache/invalidation/#build-secrets
24+
ARG VALID_SECRET_CACHE
2325
RUN --mount=type=secret,id=BUGSNAG_API_KEY,target=/run/secrets/BUGSNAG_API_KEY \
2426
--mount=type=secret,id=REACT_APP_MUI_LICENSE_KEY,target=/run/secrets/REACT_APP_MUI_LICENSE_KEY \
2527
REACT_APP_BUGSNAG_API_KEY=$(cat /run/secrets/BUGSNAG_API_KEY) \
@@ -92,7 +94,7 @@ LABEL org.opencontainers.image.title="Volumes Backup & Share" \
9294
]" \
9395
com.docker.desktop.extension.icon="https://raw.githubusercontent.com/docker/volumes-backup-extension/main/icon.svg" \
9496
com.docker.extension.changelog="<ul>\
95-
<li>Fixed current image vulnerabilities (CVEs) using Docker Scout.</li> \
97+
<li>Fix MUI missing license.</li> \
9698
</ul>" \
9799
com.docker.extension.categories="volumes"
98100

@@ -108,6 +110,7 @@ COPY --from=docker-credentials-client-builder output/dist ./host
108110

109111
RUN mkdir -p /vackup
110112

113+
ARG VALID_SECRET_CACHE
111114
RUN --mount=type=secret,id=BUGSNAG_API_KEY \
112115
BUGSNAG_API_KEY=$(cat /run/secrets/BUGSNAG_API_KEY); \
113116
echo "$BUGSNAG_API_KEY" > /tmp/bugsnag-api-key.txt

0 commit comments

Comments
 (0)