diff --git a/Dockerfile b/Dockerfile index f709ee64..cc2a6bc3 100644 --- a/Dockerfile +++ b/Dockerfile @@ -20,4 +20,5 @@ RUN npm install \ EXPOSE 3000 # Start the app using serve command -CMD [ "serve", "-s", "build" ] \ No newline at end of file +CMD [ "serve", "-s", "build" ] +# CMD ["npm", "start"] \ No newline at end of file diff --git a/README.md b/README.md index 4faa8cc5..d78aef4d 100644 --- a/README.md +++ b/README.md @@ -3,9 +3,11 @@ This is a repo for new users getting started with Docker. You can try it out using the following command. + ``` docker run -d -p 8088:80 --name welcome-to-docker docker/welcome-to-docker ``` + And open `http://localhost:8088` in your browser. # Building @@ -13,8 +15,13 @@ And open `http://localhost:8088` in your browser. Maintainers should see [MAINTAINERS.md](MAINTAINERS.md). Build and run: + ``` -docker build -t welcome-to-docker . +docker build -t welcome-to-docker . docker run -d -p 8088:3000 --name welcome-to-docker welcome-to-docker ``` + Open `http://localhost:8088` in your browser. + +docker build -t welcome-to-docker . +docker run -p 3001:3000 -v $(pwd):/app welcome-to-docker-test diff --git a/src/App.js b/src/App.js index 6dbe5011..66d05030 100644 --- a/src/App.js +++ b/src/App.js @@ -9,48 +9,10 @@ const App = () => {
- You ran your first container. + You ran your first container SHOHOOO.
-