Skip to content

Commit b411aea

Browse files
authored
Merge pull request #9 from dockersamples/new-schema-support
New schema support
2 parents 480cf8f + ad752fd commit b411aea

File tree

4 files changed

+12
-6
lines changed

4 files changed

+12
-6
lines changed

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ LABEL org.opencontainers.image.title="Labspaces" \
2323
com.docker.extension.publisher-url="https://github.com/dockersamples/labspace-extension" \
2424
com.docker.extension.additional-urls="[{\"title\":\"Create your own Labspace\",\"url\":\"https://github.com/dockersamples/labspace-starter\"}]" \
2525
com.docker.extension.categories="cloud-development" \
26-
com.docker.extension.changelog="- Persist filter settings and a few minor bug fixes"
26+
com.docker.extension.changelog="- Support for new labspace.yaml schema"
2727
COPY beaker.svg /
2828
COPY metadata.json /
2929
COPY --from=build /usr/local/app/dist /ui

src/CatalogContext.jsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,10 @@ export function CatalogContextProvider({ children }) {
7777
const allLabspaces = [...customLabspaces];
7878
catalogDetails.forEach((catalog) => {
7979
catalog.labspaces.forEach((labspace) => {
80-
allLabspaces.push({ ...labspace, catalog: { name: catalog.name, url: catalog.url } });
80+
allLabspaces.push({
81+
...labspace,
82+
catalog: { name: catalog.name, url: catalog.url },
83+
});
8184
});
8285
});
8386
return allLabspaces.sort((a, b) => {

src/Home.jsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,11 @@ export function Home() {
3939
<RunningNotice
4040
hasLabspace={hasLabspace}
4141
isRunning={!!runningLabspace}
42-
labspaceTitle={runningLabspace ? runningLabspace.title : ""}
42+
labspaceTitle={
43+
runningLabspace
44+
? (runningLabspace?.metadata?.title ?? runningLabspace.title)
45+
: ""
46+
}
4347
onRemove={stopLabspace}
4448
isStopping={stoppingLabspace}
4549
/>

src/components/Catalog/CatalogSidebar.jsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export function CatalogSidebar({ onFilterChange }) {
88
const { catalogs, tags } = useCatalogs();
99
const [searchTerm, setSearchTerm] = useState("");
1010
const [activeCategory, setActiveCategory] = useState(
11-
localStorage.getItem("labspaces.activeCategory") || null
11+
localStorage.getItem("labspaces.activeCategory") || null,
1212
);
1313
const [selectedCatalogs, setSelectedCatalogs] = useState(
1414
localStorage.getItem("labspaces.selectedCatalogs")
@@ -20,8 +20,7 @@ export function CatalogSidebar({ onFilterChange }) {
2020
useEffect(() => {
2121
if (activeCategory)
2222
localStorage.setItem("labspaces.activeCategory", activeCategory);
23-
else
24-
localStorage.removeItem("labspaces.activeCategory");
23+
else localStorage.removeItem("labspaces.activeCategory");
2524
}, [activeCategory]);
2625

2726
useEffect(() => {

0 commit comments

Comments
 (0)