Fixes ansible-lint issues

Author: bbaassssiiee

.ansible-lint

@@ -1,4 +1,3 @@
 ---
 skip_list:
   - experimental  # all rules tagged as experimental
-  - fqcn-builtins

molecule/default/converge.yml

@@ -3,10 +3,10 @@
 - name: Converge
   hosts: all
   vars:
-    role_name: "{{ lookup('env', 'MOLECULE_PROJECT_DIRECTORY') | basename }}"
+    this_role: "{{ lookup('env', 'MOLECULE_PROJECT_DIRECTORY') | basename }}"
 
   tasks:
-    - name: "Include {{ role_name }}"
+    - name: "Include {{ this_role }}"
       ansible.builtin.include_role:
-        name: "{{ role_name }}"
+        name: "{{ this_role }}"
 ...

molecule/default/verify.yml

@@ -19,7 +19,7 @@
     goss_format: tap
   tasks:
     - name: Download and install Goss
-      get_url:
+      ansible.builtin.get_url:
         url: "{{ goss_url }}"
         dest: "{{ goss_dst }}"
         sha256sum: "{{ goss_sha256sum }}"
@@ -29,34 +29,34 @@
       retries: 3
 
     - name: Copy Goss tests to remote
-      copy:
+      ansible.builtin.copy:
         src: "{{ item }}"
         dest: "{{ goss_test_directory }}/{{ item | basename }}"
         mode: 0644
       with_fileglob:
         - "{{ lookup('env', 'MOLECULE_VERIFIER_TEST_DIRECTORY') }}/test_*.yml"
 
     - name: Register test files
-      shell: "ls {{ goss_test_directory }}/test_*.yml"
+      ansible.builtin.shell: "ls {{ goss_test_directory }}/test_*.yml"
       changed_when: false
       register: test_files
 
     - name: Execute Goss tests
       environment:
-        # yamllint disable-line rule:line-length
+        # yamllint disable rule:line-length
         PATH: '/opt/rh/rh-git218/root/usr/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'
-      command: "{{ goss_dst }} -g {{ item }} validate -f {{ goss_format }}"
+      ansible.builtin.command: "{{ goss_dst }} -g {{ item }} validate -f {{ goss_format }}"
       changed_when: false
       register: test_results
       with_items: "{{ test_files.stdout_lines }}"
 
     - name: Display details about the Goss results
-      debug:
+      ansible.builtin.debug:
         msg: "{{ item.stdout_lines }}"
       with_items: "{{ test_results.results }}"
 
     - name: Fail when tests fail
-      fail:
+      ansible.builtin.fail:
         msg: "Goss failed to validate"
       when: item.rc != 0
       with_items: "{{ test_results.results }}"

tasks/main.yml

@@ -1,7 +1,7 @@
 ---
 
 - name: Resolve platform specific vars
-  include_vars: "{{ item }}"
+  ansible.builtin.include_vars: "{{ item }}"
   with_first_found:
     - files:
         - "{{ ansible_distribution }}-{{ ansible_distribution_release }}.yml"
@@ -12,51 +12,51 @@
         - '{{ role_path }}/vars'
 
 - name: Install GPG package
-  package:
+  ansible.builtin.package:
     name: "{{ gpg_package | default(['gpg']) }}"
     update_cache: true
     state: present
 
 - name: Create GPG agent config directory
-  file:
+  ansible.builtin.file:
     path: /etc/skel/.gnupg
     state: directory
     mode: 0700
 
 - name: Install GPG agent config file
-  template:
+  ansible.builtin.template:
     src: gpg-agent.conf
     dest: /etc/skel/.gnupg/
     mode: 0600
 
 - name: Check if /etc/skel/.bash_profile exists
-  stat:
+  ansible.builtin.stat:
     path: /etc/skel/.bash_profile
   register: bash_profile
 
 - name: Create .bash_profile
   when: not bash_profile.stat.exists
-  copy:
+  ansible.builtin.copy:
     content: ''
     dest: /etc/skel/.bash_profile
     mode: 0644
 
 - name: Configure environment for GPG agent
-  lineinfile:
+  ansible.builtin.lineinfile:
     path: /etc/skel/.bash_profile
     regexp: '^export GPG_TTY.*'
     line: 'export GPG_TTY=$(tty)'
     state: present
 
 - name: Configure bash_profile for GPG agent
-  lineinfile:
+  ansible.builtin.lineinfile:
     path: /etc/skel/.bash_profile
     regexp: '^gpg-agent --daemon.*'
     line: 'gpg-agent --daemon --write-env-file "${HOME}/.gpg-agent-info"'
     state: present
 
 - name: Configure bashrc for GPG agent
-  blockinfile:
+  ansible.builtin.blockinfile:
     path: /etc/skel/.bashrc
     marker: "# {mark} ANSIBLE MANAGED BLOCK"
     block: |