Skip to content

Commit 9457c0c

Browse files
removed as much as possible default parameters
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
1 parent 3adbe79 commit 9457c0c

File tree

2 files changed

+20
-12
lines changed

2 files changed

+20
-12
lines changed

app/pybind_parse.cpp

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -584,14 +584,14 @@ Sanitize table cells with specified parameters and return the processed JSON.
584584
[](docling::docling_sanitizer &self,
585585
double horizontal_cell_tolerance,
586586
bool enforce_same_font,
587-
double space_width_factor_for_merge = 1.0) -> nlohmann::json {
587+
double space_width_factor_for_merge/* = 1.0*/) -> nlohmann::json {
588588
return self.create_word_cells(horizontal_cell_tolerance,
589589
enforce_same_font,
590590
space_width_factor_for_merge);
591591
},
592-
pybind11::arg("horizontal_cell_tolerance")=1.0,
593-
pybind11::arg("enforce_same_font")=true,
594-
pybind11::arg("space_width_factor_for_merge")=0.33,
592+
pybind11::arg("horizontal_cell_tolerance"), // =1.0,
593+
pybind11::arg("enforce_same_font"), //=true,
594+
pybind11::arg("space_width_factor_for_merge"), //=0.33,
595595
R"(
596596
Create word cells
597597
@@ -607,17 +607,17 @@ Sanitize table cells with specified parameters and return the processed JSON.
607607
[](docling::docling_sanitizer &self,
608608
double horizontal_cell_tolerance,
609609
bool enforce_same_font,
610-
double space_width_factor_for_merge = 1.0,
611-
double space_width_factor_for_merge_with_space = 0.33) -> nlohmann::json {
610+
double space_width_factor_for_merge /*= 1.0*/,
611+
double space_width_factor_for_merge_with_space /*= 0.33*/) -> nlohmann::json {
612612
return self.create_line_cells(horizontal_cell_tolerance,
613613
enforce_same_font,
614614
space_width_factor_for_merge,
615615
space_width_factor_for_merge_with_space);
616616
},
617-
pybind11::arg("horizontal_cell_tolerance")=1.0,
618-
pybind11::arg("enforce_same_font")=true,
619-
pybind11::arg("space_width_factor_for_merge")=1.0,
620-
pybind11::arg("space_width_factor_for_merge_with_space")=0.33,
617+
pybind11::arg("horizontal_cell_tolerance"), //=1.0,
618+
pybind11::arg("enforce_same_font"), //=true,
619+
pybind11::arg("space_width_factor_for_merge"), //=1.0,
620+
pybind11::arg("space_width_factor_for_merge_with_space"), //=0.33,
621621
R"(
622622
Create line cells
623623

docling_parse/pdf_parser.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,9 @@ def _to_segmented_page(
442442
segmented_page.word_cells = self._to_cells(page["word_cells"])
443443
segmented_page.has_words = len(segmented_page.word_cells) > 0
444444
elif keep_chars:
445-
logging.warning("`words` will be created for segmented_page in an inefficient way!")
445+
logging.warning(
446+
"`words` will be created for segmented_page in an inefficient way!"
447+
)
446448
self._create_word_cells(segmented_page, enforce_same_font=enforce_same_font)
447449
else:
448450
logging.warning("No `words` will be created for segmented_page")
@@ -451,7 +453,9 @@ def _to_segmented_page(
451453
segmented_page.textline_cells = self._to_cells(page["line_cells"])
452454
segmented_page.has_lines = len(segmented_page.textline_cells) > 0
453455
elif keep_chars:
454-
logging.warning("`text_lines` will be created for segmented_page in an inefficient way!")
456+
logging.warning(
457+
"`text_lines` will be created for segmented_page in an inefficient way!"
458+
)
455459
self._create_textline_cells(
456460
segmented_page, enforce_same_font=enforce_same_font
457461
)
@@ -464,6 +468,7 @@ def _create_word_cells(
464468
self,
465469
segmented_page: SegmentedPdfPage,
466470
*,
471+
horizontal_cell_tolerance: float = 1.0,
467472
space_width_factor_for_merge: float = 0.33,
468473
enforce_same_font: bool = True,
469474
_loglevel: str = "fatal",
@@ -485,6 +490,7 @@ def _create_word_cells(
485490

486491
# data = sanitizer.create_word_cells(space_width_factor_for_merge=0.33)
487492
data = sanitizer.create_word_cells(
493+
horizontal_cell_tolerance=horizontal_cell_tolerance,
488494
space_width_factor_for_merge=space_width_factor_for_merge,
489495
enforce_same_font=enforce_same_font,
490496
)
@@ -500,6 +506,7 @@ def _create_textline_cells(
500506
self,
501507
segmented_page: SegmentedPdfPage,
502508
*,
509+
horizontal_cell_tolerance: float = 1.0,
503510
space_width_factor_for_merge: float = 1.0,
504511
space_width_factor_for_merge_with_space: float = 0.33,
505512
enforce_same_font: bool = True,
@@ -526,6 +533,7 @@ def _create_textline_cells(
526533

527534
# data = sanitizer.create_line_cells()
528535
data = sanitizer.create_line_cells(
536+
horizontal_cell_tolerance=horizontal_cell_tolerance,
529537
space_width_factor_for_merge=space_width_factor_for_merge,
530538
space_width_factor_for_merge_with_space=space_width_factor_for_merge_with_space,
531539
enforce_same_font=enforce_same_font,

0 commit comments

Comments
 (0)