test: fix picture checks in shared verifier (#3130)

Signed-off-by: Hassan Raza <raihassanraza10@gmail.com>

Author: M-Hassan-Raza

tests/test_verify_utils.py

@@ -1,7 +1,8 @@
 import pytest
-from docling_core.types.doc import DoclingDocument, ProvenanceItem
+from docling_core.types.doc import DoclingDocument, ImageRef, ProvenanceItem
 from docling_core.types.doc.base import BoundingBox, Size
 from docling_core.types.doc.labels import DocItemLabel
+from PIL import Image
 
 from tests.verify_utils import verify_docitems
 
@@ -24,6 +25,14 @@ def _make_doc_with_bbox(
     return doc
 
 
+def _make_doc_with_picture(*, image_size: tuple[int, int]) -> DoclingDocument:
+    doc = DoclingDocument(name="test")
+    doc.add_picture(
+        image=ImageRef.from_pil(Image.new("RGB", image_size, "red"), dpi=72)
+    )
+    return doc
+
+
 def test_verify_docitems_allows_small_bbox_variance_for_non_fuzzy_docs():
     verify_docitems(
         doc_pred=_make_doc_with_bbox(left=11.53),
@@ -78,3 +87,29 @@ def test_verify_docitems_rejects_bbox_presence_mismatch():
             fuzzy=False,
             pdf_filename="fixture.json",
         )
+
+
+def test_verify_docitems_rejects_picture_count_mismatch():
+    doc_true = _make_doc_with_picture(image_size=(2, 2))
+    doc_pred = DoclingDocument(name="test")
+
+    with pytest.raises(AssertionError, match="Picture lengths do not match"):
+        verify_docitems(
+            doc_pred=doc_pred,
+            doc_true=doc_true,
+            fuzzy=False,
+            pdf_filename="fixture.json",
+        )
+
+
+def test_verify_docitems_uses_predicted_picture_image():
+    doc_true = _make_doc_with_picture(image_size=(2, 2))
+    doc_pred = _make_doc_with_picture(image_size=(3, 2))
+
+    with pytest.raises(AssertionError):
+        verify_docitems(
+            doc_pred=doc_pred,
+            doc_true=doc_true,
+            fuzzy=False,
+            pdf_filename="fixture.json",
+        )

tests/verify_utils.py

@@ -276,6 +276,9 @@ def verify_docitems(
     assert len(doc_true.tables) == len(doc_pred.tables), (
         f"[{pdf_filename}] document has different count of tables than expected."
     )
+    assert len(doc_true.pictures) == len(doc_pred.pictures), (
+        f"[{pdf_filename}] Picture lengths do not match: {len(doc_true.pictures)} != {len(doc_pred.pictures)}"
+    )
 
     for (true_item, _true_level), (pred_item, _pred_level) in zip(
         doc_true.iterate_items(), doc_pred.iterate_items()
@@ -359,7 +362,7 @@ def verify_docitems(
             )
 
             true_image = true_item.get_image(doc=doc_true)
-            pred_image = true_item.get_image(doc=doc_pred)
+            pred_image = pred_item.get_image(doc=doc_pred)
             if true_image is not None:
                 assert verify_picture_image_v2(true_image, pred_image), (
                     f"[{pdf_filename}] Picture image mismatch"