Merge pull request #171 from kopischke/fix/sanitizePath

Fix findParentNodeModules failing on paths with non-URI legal chars

Author: neogeek

packages/doxdox-cli/src/index.ts

@@ -6,6 +6,8 @@ import { promises as fs } from 'fs';
 
 import { dirname, join } from 'path';
 
+import { fileURLToPath } from 'url';
+
 import { globby } from 'globby';
 
 import updateNotifier from 'update-notifier';
@@ -19,8 +21,7 @@ import doxdox, {
     getRootDirPath,
     loadPlugin,
     parseConfigFromCLI,
-    parseIgnoreConfig,
-    sanitizePath
+    parseIgnoreConfig
 } from 'doxdox-core';
 
 import { Doc, File } from 'doxdox-core';
@@ -113,7 +114,7 @@ const overridePackage = String(
     const cliConfig = parseConfigFromCLI(args.raw);
 
     const nodeModulesDir = await findParentNodeModules(
-        dirname(sanitizePath(import.meta.url))
+        dirname(fileURLToPath(import.meta.url))
     );
 
     if (!nodeModulesDir) {

packages/doxdox-core/src/utils.test.ts

@@ -11,7 +11,6 @@ import {
     isFile,
     parseConfigFromCLI,
     parseIgnoreConfig,
-    sanitizePath,
     slugify
 } from './utils';
 
@@ -169,18 +168,6 @@ describe('utils', () => {
         });
     });
 
-    describe('sanitizePath', () => {
-        it('sanitize path', () => {
-            expect(
-                sanitizePath(
-                    'file:///Users/scottdoxey/git/github/doxdox/packages/doxdox-cli/dist/src/index.js'
-                )
-            ).toEqual(
-                '/Users/scottdoxey/git/github/doxdox/packages/doxdox-cli/dist/src/index.js'
-            );
-        });
-    });
-
     describe('slugify', () => {
         it('slugify path', () => {
             expect(slugify('./src/utils.ts')).toEqual('src-utils-ts');

packages/doxdox-core/src/utils.ts

@@ -189,16 +189,6 @@ export const parseIgnoreConfig = (contents: string): string[] =>
         .filter(line => line.trim())
         .map(line => `!${line.trim().replace(/^!/, '')}`);
 
-/**
- * Sanitizes given path or url.
- *
- * @param {string} [url] Path or url.
- * @return {Promise<string>} Sanitized path.
- * @public
- */
-
-export const sanitizePath = (path: string): string => new URL(path).pathname;
-
 /**
  * Slugify a value for use as an anchor.
  *