fix: update relative link handling

Author: sy-records

src/core/render/compiler/link.js

@@ -12,40 +12,39 @@ export const linkCompiler = ({
     const attrs = [];
     const text = this.parser.parseInline(tokens) || '';
     const { str, config } = getAndRemoveConfig(title);
+    const isAbsolute = isAbsolutePath(href);
+    const isNotCompilable = compiler._matchNotCompileLink(href);
+    const isMailto = href.startsWith('mailto:');
+
     linkTarget = config.target || linkTarget;
     linkRel =
       linkTarget === '_blank'
         ? compiler.config.externalLinkRel || 'noopener'
         : '';
     title = str;
 
-    if (
-      !isAbsolutePath(href) &&
-      !compiler._matchNotCompileLink(href) &&
-      !config.ignore
-    ) {
+    if (!isAbsolute && !isNotCompilable && !config.ignore) {
       if (href === compiler.config.homepage) {
         href = 'README';
       }
-
       href = router.toURL(href, null, router.getCurrentPath());
 
-      if (config.target) {
-        href.indexOf('mailto:') !== 0 && attrs.push(`target="${linkTarget}"`);
+      if (config.target && !isMailto) {
+        attrs.push(`target="${linkTarget}"`);
       }
     } else {
-      if (!isAbsolutePath(href) && href.slice(0, 2) === './') {
-        href =
-          document.URL.replace(/\/(?!.*\/).*/, '/').replace('#/./', '') + href;
+      if (!isAbsolute && !isNotCompilable && href.startsWith('./')) {
+        href = router
+          .toURL(href, null, router.getCurrentPath())
+          .replace(/^#\//, '/');
+      }
+
+      if (!isMailto) {
+        attrs.push(`target="${linkTarget}"`);
+        if (linkRel !== '') {
+          attrs.push(`rel="${linkRel}"`);
+        }
       }
-      attrs.push(href.indexOf('mailto:') === 0 ? '' : `target="${linkTarget}"`);
-      attrs.push(
-        href.indexOf('mailto:') === 0
-          ? ''
-          : linkRel !== ''
-            ? ` rel="${linkRel}"`
-            : '',
-      );
     }
 
     if (config.disabled) {

test/integration/render.test.js

@@ -229,7 +229,7 @@ describe('render', function () {
       const output = window.marked('[alt text](http://url)');
 
       expect(output).toMatchInlineSnapshot(
-        '"<p><a href="http://url" target="_blank"  rel="noopener">alt text</a></p>"',
+        `"<p><a href="http://url" target="_blank" rel="noopener">alt text</a></p>"`,
       );
     });
 
@@ -241,23 +241,23 @@ describe('render', function () {
       const output = window.marked('[alt text](http://www.example.com)');
 
       expect(output).toMatchInlineSnapshot(
-        '"<p><a href="http://www.example.com" target="_blank"  rel="noopener">alt text</a></p>"',
+        `"<p><a href="http://www.example.com" target="_blank" rel="noopener">alt text</a></p>"`,
       );
     });
 
     test('disabled', async function () {
       const output = window.marked("[alt text](http://url ':disabled')");
 
       expect(output).toMatchInlineSnapshot(
-        '"<p><a href="javascript:void(0)" target="_blank"  rel="noopener" disabled>alt text</a></p>"',
+        `"<p><a href="javascript:void(0)" target="_blank" rel="noopener" disabled>alt text</a></p>"`,
       );
     });
 
     test('target for absolute path', async function () {
       const output = window.marked("[alt text](http://url ':target=_self')");
 
       expect(output).toMatchInlineSnapshot(
-        '"<p><a href="http://url" target="_self" >alt text</a></p>"',
+        `"<p><a href="http://url" target="_self">alt text</a></p>"`,
       );
     });
 
@@ -275,7 +275,7 @@ describe('render', function () {
       );
 
       expect(output).toMatchInlineSnapshot(
-        '"<p><a href="http://url" target="_blank"  rel="noopener" class="someCssClass">alt text</a></p>"',
+        `"<p><a href="http://url" target="_blank" rel="noopener" class="someCssClass">alt text</a></p>"`,
       );
     });
 
@@ -285,15 +285,15 @@ describe('render', function () {
       );
 
       expect(output).toMatchInlineSnapshot(
-        `"<p><a href="http://url" target="_blank"  rel="noopener" class="someCssClass anotherCssClass">alt text</a></p>"`,
+        `"<p><a href="http://url" target="_blank" rel="noopener" class="someCssClass anotherCssClass">alt text</a></p>"`,
       );
     });
 
     test('id', async function () {
       const output = window.marked("[alt text](http://url ':id=someCssID')");
 
       expect(output).toMatchInlineSnapshot(
-        '"<p><a href="http://url" target="_blank"  rel="noopener" id="someCssID">alt text</a></p>"',
+        `"<p><a href="http://url" target="_blank" rel="noopener" id="someCssID">alt text</a></p>"`,
       );
     });
   });