-
-
Couldn't load subscription status.
- Fork 5.8k
style: CSS updates for coverpage, iframe dark mode transparency and codeblock contast #2593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
not sure why clicking on Quick start on Coverpage only scrolls down halfway
I was unable to reproduce the issue. I reproduced it. I need to click on the title instead of the button.
|
The cause of the problem is the anchor point. When clicked, it scrolls to the anchor point position, but
|
|
Thank you very much @sy-records ! I will post a follow-up issue on the coverpage link question. |
Summary
CSS updates for the following:
Also available for review and testing in codesandbox:
https://codesandbox.io/p/sandbox/docsify-v5-css-issues-6r26v7
View
index.htmlto uncomment related CSS fix to see proposed changes, etc.And here is the same test Docsify site using the updated theme files in this PR:
https://paulhibbitts.github.io/docsify-v5-css-issues/#/
(not sure why clicking on Quick start on Coverpage only scrolls down halfway, I think this is a pretty recent issue and also seems to be on https://preview.docsifyjs.org/#/ now but not in RC-1 https://paulhibbitts.github.io/docsify-v5-rc-1-coverpage/)
Related issue, if any:
What kind of change does this PR introduce?
For any code change,
Does this PR introduce a breaking change?
Tested in the following browsers: