-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
fix: adjust intersection observer threshold for sticky class toggle #2637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sy-records is attempting to deploy a commit to the Docsify Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Thanks @sy-records , happy to help test but unclear of the setup I need to try? |
|
Directly modify the README in the docs using the content he mentioned to reproduce the issue. |
|
Thanks @sy-records , I've made a new Sandbox and used the build from #2635 but do not see the issue, am I still missing something? https://codesandbox.io/p/sandbox/docsify-v5-template-sticky-class-toggle-l6wrkj |
|
Just a little content is needed. 2025-12-01.14.39.33.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much @sy-records , I was finally able to replicate the issue:
2025-12-01_07-01-29.mp4
I tested with the PR build, and the issue looks to be addressed:
https://paulhibbitts.github.io/docsify-v5-rc/#/?id=codeblock
Good catch! Thanks, Paul
|
Since I submitted the PR from a forked repository, deployment requires approval. |

Summary
During test #2635, it was discovered that enabling cover and placing its content in the readme causes infinite flickering.
Related issue, if any:
What kind of change does this PR introduce?
For any code change,
Does this PR introduce a breaking change?
Tested in the following browsers: