Fix leaks: missing Drop for Endpoint & wrongly retained database in CBLReplicatorConfiguration

Author: Nao-ris

src/replicator.rs

@@ -25,7 +25,7 @@ use std::{
 };
 use crate::{
     CblRef, Database, Dict, Document, Error, ListenerToken, MutableDict, Result, check_error,
-    release, retain,
+    release,
     slice::{from_str, self},
     c_api::{
         CBLListener_Remove, CBLAuth_CreatePassword, CBLAuth_CreateSession, CBLAuthenticator,
@@ -107,6 +107,14 @@ impl Clone for Endpoint {
     }
 }
 
+impl Drop for Endpoint {
+    fn drop(&mut self) {
+        unsafe {
+            release(self.get_ref());
+        }
+    }
+}
+
 /** An opaque object representing authentication credentials for a remote server. */
 #[derive(Debug, PartialEq, Eq)]
 pub struct Authenticator {
@@ -786,7 +794,7 @@ impl Replicator {
                 database: config
                     .database
                     .as_ref()
-                    .map(|d| retain(d.get_ref()))
+                    .map(|d| d.get_ref())
                     .unwrap_or(ptr::null_mut()),
                 endpoint: config.endpoint.get_ref(),
                 replicatorType: config.replicator_type.clone().into(),

tests/utils.rs

@@ -68,6 +68,10 @@ impl Drop for LeakChecker {
 
             if self.start_instance_count != self.end_instance_count {
                 info!("Leaks detected :-(");
+                info!(
+                    "Instances before: {} | Instances after: {}",
+                    self.start_instance_count, self.end_instance_count
+                );
                 dump_instances();
                 panic!("Memory leaks detected");
                 // NOTE: This failure is likely to happen if the tests run multi-threaded, as happens by
@@ -170,6 +174,8 @@ impl ReplicationTwoDbsTester {
     ) -> Self {
         init_logging();
 
+        let _leak_checker = LeakChecker::new();
+
         // Create databases
         let tmp_dir = TempDir::new("cbl_rust").expect("create temp dir");
         let tmp_dir_path = tmp_dir.path();
@@ -211,7 +217,7 @@ impl ReplicationTwoDbsTester {
             central_database,
             replicator,
             replicator_continuous,
-            _leak_checker: LeakChecker::new(),
+            _leak_checker,
         }
     }
 
@@ -301,6 +307,8 @@ impl ReplicationThreeDbsTester {
     ) -> Self {
         init_logging();
 
+        let _leak_checker = LeakChecker::new();
+
         // Create databases
         let tmp_dir = TempDir::new("cbl_rust").expect("create temp dir");
         let local_database_1_configuration = DatabaseConfiguration {
@@ -362,7 +370,7 @@ impl ReplicationThreeDbsTester {
             replicator_1_continuous,
             replicator_2,
             replicator_2_continuous,
-            _leak_checker: LeakChecker::new(),
+            _leak_checker,
         }
     }