feat(EN-2932): Migrate github secrets to vault #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Compilation issues are not related to the changes made for STEP-18. I can reproduce locally and tried building the Docker image for commit d4d6ae1 which was fine before and it's now failing... |
karouf
requested review from
bpaquet,
achouippe,
gcxRun and
papey
as code owners
karouf
deleted the
EN-2932-Migrate-secrets-usage-to-STEP-18-for-Doctolib-Org
branch
karouf
added a commit
that referenced
this pull request
Oct 6, 2025
As discussed with @benassipaul and @bpaquet this repo needs to use an ARN to push the Docker image but as an org we don't want to expose this ARN so it will be set up as a GHA secret. - **Revert "feat(EN-2932): Migrate github secrets to vault (#56)"** - **Revert "feat(EN-2932): Migrate github secrets to vault (#55)"**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transition to Secure GitHub Actions Workflows (STEP-18 Compliance)
As part of our security enhancements, we have done the legwork to migrate approximately 100 of our 420 repositories left to no longer store secrets on GitHub servers, complying with STEP-18. We need your help to finalize this transition.
This change is required by Platform Security for all repositories that use GitHub Actions workflows.
Why This Change?
What to Do?
Need Help?
Next Steps