check pg version directly with the current connection

Author: CharlesDelannoy

lib/safe-pg-migrations/plugins/idempotent_statements.rb

@@ -23,14 +23,18 @@ def add_column(table_name, column_name, type, **options)
         error_message = "/!\\ Column '#{column_name}' already exists in '#{table_name}' with a different type"
         raise error_message
       end
+
       options_without_default_value_backfill = options.except(:default_value_backfill)
-      return super(table_name, column_name, type, **options_without_default_value_backfill) unless column_exists?(table_name, column_name, type)
 
-      log_message(<<~MESSAGE.squish
-        /!\\ Column '#{column_name}' already exists in '#{table_name}' with the same type (#{type}).
-        Skipping statement.
-      MESSAGE
-                 )
+      if column_exists?(table_name, column_name, type)
+        log_message(<<~MESSAGE.squish
+          /!\\ Column '#{column_name}' already exists in '#{table_name}' with the same type (#{type}).
+          Skipping statement.
+        MESSAGE
+                   )
+      else
+        super(table_name, column_name, type, **options_without_default_value_backfill)
+      end
     end
 
     def remove_column(table_name, column_name, type = nil, **options)

test/StatementInsurer/change_column_null_test.rb

@@ -127,7 +127,7 @@ def skip_if_unmet_requirements!
 
     def met_requirements?
       Gem::Requirement.new('>6.1').satisfied_by?(Gem::Version.new(::ActiveRecord::VERSION::STRING)) &&
-        SafePgMigrations.pg_version_num >= 120_000
+        SafePgMigrations.get_pg_version_num(@connection) >= 120_000
     end
   end
 end