not adding index concurrently if table creation (#32)

* Not adding index concurrently if table creation

* Using :default instead of nil

Author: Thomas Hareau

lib/safe-pg-migrations/plugins/statement_insurer.rb

@@ -4,7 +4,7 @@ module SafePgMigrations
   module StatementInsurer
     PG_11_VERSION_NUM = 110_000
 
-    %i[change_column_null change_column create_table].each do |method|
+    %i[change_column_null change_column].each do |method|
       define_method method do |*args, &block|
         with_setting(:statement_timeout, SafePgMigrations.config.pg_safe_timeout) { super(*args, &block) }
       end
@@ -46,8 +46,25 @@ def add_foreign_key(from_table, to_table, **options)
       without_statement_timeout { validate_foreign_key from_table, options_or_to_table } unless validate_present
     end
 
+    def create_table(*)
+      with_setting(:statement_timeout, SafePgMigrations.config.pg_safe_timeout) do
+        super do |td|
+          yield td if block_given?
+          td.indexes.map! do |key, index_options|
+            index_options[:algorithm] ||= :default
+            [key, index_options]
+          end
+        end
+      end
+    end
+
     def add_index(table_name, column_name, **options)
-      options[:algorithm] = :concurrently
+      if options[:algorithm] == :default
+        options.delete :algorithm
+      else
+        options[:algorithm] = :concurrently
+      end
+
       SafePgMigrations.say_method_call(:add_index, table_name, column_name, options)
 
       without_timeout { super }

test/create_table_test.rb

@@ -44,7 +44,7 @@ def change
       # Create the index.
       'SET statement_timeout TO 0',
       'SET lock_timeout TO 0',
-      'CREATE INDEX CONCURRENTLY "index_users_on_user_id" ON "users" ("user_id")',
+      'CREATE INDEX "index_users_on_user_id" ON "users" ("user_id")',
       "SET lock_timeout TO '5s'",
       "SET statement_timeout TO '5s'",
 
@@ -87,7 +87,7 @@ def change
       "SET statement_timeout TO '5s'",
       'SET statement_timeout TO 0',
       'SET lock_timeout TO 0',
-      'CREATE INDEX CONCURRENTLY "index_users_on_email" ON "users" ("email")',
+      'CREATE INDEX "index_users_on_email" ON "users" ("email")',
       "SET lock_timeout TO '5s'",
       "SET statement_timeout TO '5s'",
       "SET statement_timeout TO '70s'",