Skip to content

Commit df907d5

Browse files
committed
ignore if lock timeout is nil
1 parent 2f59f80 commit df907d5

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

lib/safe-pg-migrations/configuration.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,16 @@
55
module SafePgMigrations
66
class Configuration
77
attr_accessor(*%i[
8+
backfill_batch_size
9+
backfill_pause
810
blocking_activity_logger_margin
911
blocking_activity_logger_verbose
1012
default_value_backfill_threshold
11-
backfill_batch_size
12-
backfill_pause
13-
retry_delay
13+
lock_timeout
1414
max_tries
1515
max_lock_timeout
16+
retry_delay
1617
sensitive_logger
17-
lock_timeout
1818
])
1919
attr_reader :safe_timeout
2020

lib/safe-pg-migrations/plugins/statement_retrier.rb

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,12 @@ def retry_if_lock_timeout
2121
raise if transaction_open? # Retrying is useless if we're inside a transaction.
2222
raise if number_of_retries >= SafePgMigrations.config.max_tries
2323

24-
if SafePgMigrations.config.lock_timeout < SafePgMigrations.config.max_lock_timeout
25-
SafePgMigrations.config.lock_timeout = SafePgMigrations.config.lock_timeout * number_of_retries
26-
else
27-
SafePgMigrations.config.lock_timeout = SafePgMigrations.config.max_lock_timeout
24+
unless SafePgMigrations.config.lock_timeout.nil?
25+
if SafePgMigrations.config.lock_timeout < SafePgMigrations.config.max_lock_timeout
26+
SafePgMigrations.config.lock_timeout = SafePgMigrations.config.lock_timeout * number_of_retries
27+
else
28+
SafePgMigrations.config.lock_timeout = SafePgMigrations.config.max_lock_timeout
29+
end
2830
end
2931

3032
retry_delay = SafePgMigrations.config.retry_delay

0 commit comments

Comments
 (0)