attempt at fixing an idempotence on roleparam resource

Author: achellouche

postgresql/resource_postgresql_alter_role.go

@@ -128,12 +128,7 @@ func readAlterRole(db QueryAble, d *schema.ResourceData) error {
 	alterRoleID := d.Id()
 	alterParameterKey := d.Get("parameter_key")
 
-	values := []interface{}{
-		&roleName,
-		&roleParameters,
-	}
-
-	err := db.QueryRow(getAlterRoleQuery, d.Get("role_name")).Scan(values...)
+	err := db.QueryRow(getAlterRoleQuery, d.Get("role_name")).Scan(&roleName, &roleParameters)
 	switch {
 	case err == sql.ErrNoRows:
 		log.Printf("[WARN] PostgreSQL alter role (%q) not found", alterRoleID)
@@ -148,16 +143,16 @@ func readAlterRole(db QueryAble, d *schema.ResourceData) error {
 	d.Set("role_name", roleName)
 	d.SetId(generateAlterRoleID(d))
 
-	for _, v := range roleParameters {
-		parameter := string(v)
+	parameters_string := strings.TrimPrefix(strings.TrimSuffix(string(roleParameters), '}'), '{')
+	parameters = strings.Split(parameters_string, ",")
+	for _, parameter := range parameters {
 		parameterKey := strings.Split(parameter, "=")[0]
 		parameterValue := strings.Split(parameter, "=")[1]
 		if parameterKey == alterParameterKey {
 			d.Set("parameter_key", parameterKey)
 			d.Set("parameter_value", parameterValue)
 		}
 	}
-
 	return nil
 }