Stop nested loops with a single break sentence

phansys · franmomu · commit 056bf3e66953 · 2021-11-18T14:16:07.000+01:00
diff --git a/src/Loggable/Document/Repository/LogEntryRepository.php b/src/Loggable/Document/Repository/LogEntryRepository.php
@@ -145,12 +145,9 @@ private function getLoggableListener()
                     if ($listener instanceof LoggableListener) {
                         $this->listener = $listener;
 
-                        break;
+                        break 2;
                     }
                 }
-                if ($this->listener) {
-                    break;
-                }
             }
 
             if (null === $this->listener) {
diff --git a/src/Loggable/Entity/Repository/LogEntryRepository.php b/src/Loggable/Entity/Repository/LogEntryRepository.php
@@ -146,12 +146,9 @@ private function getLoggableListener()
                     if ($listener instanceof LoggableListener) {
                         $this->listener = $listener;
 
-                        break;
+                        break 2;
                     }
                 }
-                if ($this->listener) {
-                    break;
-                }
             }
 
             if (null === $this->listener) {
diff --git a/src/SoftDeleteable/Query/TreeWalker/SoftDeleteableWalker.php b/src/SoftDeleteable/Query/TreeWalker/SoftDeleteableWalker.php
@@ -94,12 +94,9 @@ private function getSoftDeleteableListener()
                     if ($listener instanceof SoftDeleteableListener) {
                         $this->listener = $listener;
 
-                        break;
+                        break 2;
                     }
                 }
-                if ($this->listener) {
-                    break;
-                }
             }
 
             if (null === $this->listener) {
diff --git a/src/Sortable/Entity/Repository/SortableRepository.php b/src/Sortable/Entity/Repository/SortableRepository.php
@@ -34,12 +34,9 @@ public function __construct(EntityManagerInterface $em, ClassMetadata $class)
                 if ($listener instanceof SortableListener) {
                     $sortableListener = $listener;
 
-                    break;
+                    break 2;
                 }
             }
-            if ($sortableListener) {
-                break;
-            }
         }
 
         if (null === $sortableListener) {
diff --git a/src/Translatable/Hydrator/ORM/ObjectHydrator.php b/src/Translatable/Hydrator/ORM/ObjectHydrator.php
@@ -62,12 +62,9 @@ protected function getTranslatableListener()
                 if ($listener instanceof TranslatableListener) {
                     $translatableListener = $listener;
 
-                    break;
+                    break 2;
                 }
             }
-            if ($translatableListener) {
-                break;
-            }
         }
 
         if (null === $translatableListener) {
diff --git a/src/Translatable/Hydrator/ORM/SimpleObjectHydrator.php b/src/Translatable/Hydrator/ORM/SimpleObjectHydrator.php
@@ -62,12 +62,9 @@ protected function getTranslatableListener()
                 if ($listener instanceof TranslatableListener) {
                     $translatableListener = $listener;
 
-                    break;
+                    break 2;
                 }
             }
-            if ($translatableListener) {
-                break;
-            }
         }
 
         if (null === $translatableListener) {
diff --git a/src/Tree/Document/MongoDB/Repository/AbstractTreeRepository.php b/src/Tree/Document/MongoDB/Repository/AbstractTreeRepository.php
@@ -36,12 +36,9 @@ public function __construct(DocumentManager $em, UnitOfWork $uow, ClassMetadata
                 if ($listener instanceof \Gedmo\Tree\TreeListener) {
                     $treeListener = $listener;
 
-                    break;
+                    break 2;
                 }
             }
-            if ($treeListener) {
-                break;
-            }
         }
 
         if (null === $treeListener) {
diff --git a/src/Tree/Entity/Repository/AbstractTreeRepository.php b/src/Tree/Entity/Repository/AbstractTreeRepository.php
@@ -38,12 +38,9 @@ public function __construct(EntityManagerInterface $em, ClassMetadata $class)
                 if ($listener instanceof TreeListener) {
                     $treeListener = $listener;
 
-                    break;
+                    break 2;
                 }
             }
-            if ($treeListener) {
-                break;
-            }
         }
 
         if (null === $treeListener) {

Original file line number	Diff line number	Diff line change
`@@ -145,12 +145,9 @@ private function getLoggableListener()`
`145`	`145`	`if ($listener instanceof LoggableListener) {`
`146`	`146`	`$this->listener = $listener;`
`147`	`147`
`148`		`- break;`
	`148`	`+ break 2;`
`149`	`149`	`}`
`150`	`150`	`}`
`151`		`- if ($this->listener) {`
`152`		`- break;`
`153`		`- }`
`154`	`151`	`}`
`155`	`152`
`156`	`153`	`if (null === $this->listener) {`
Original file line number	Diff line number	Diff line change
`@@ -146,12 +146,9 @@ private function getLoggableListener()`
`146`	`146`	`if ($listener instanceof LoggableListener) {`
`147`	`147`	`$this->listener = $listener;`
`148`	`148`
`149`		`- break;`
	`149`	`+ break 2;`
`150`	`150`	`}`
`151`	`151`	`}`
`152`		`- if ($this->listener) {`
`153`		`- break;`
`154`		`- }`
`155`	`152`	`}`
`156`	`153`
`157`	`154`	`if (null === $this->listener) {`
Original file line number	Diff line number	Diff line change
`@@ -94,12 +94,9 @@ private function getSoftDeleteableListener()`
`94`	`94`	`if ($listener instanceof SoftDeleteableListener) {`
`95`	`95`	`$this->listener = $listener;`
`96`	`96`
`97`		`- break;`
	`97`	`+ break 2;`
`98`	`98`	`}`
`99`	`99`	`}`
`100`		`- if ($this->listener) {`
`101`		`- break;`
`102`		`- }`
`103`	`100`	`}`
`104`	`101`
`105`	`102`	`if (null === $this->listener) {`
Original file line number	Diff line number	Diff line change
`@@ -34,12 +34,9 @@ public function __construct(EntityManagerInterface $em, ClassMetadata $class)`
`34`	`34`	`if ($listener instanceof SortableListener) {`
`35`	`35`	`$sortableListener = $listener;`
`36`	`36`
`37`		`- break;`
	`37`	`+ break 2;`
`38`	`38`	`}`
`39`	`39`	`}`
`40`		`- if ($sortableListener) {`
`41`		`- break;`
`42`		`- }`
`43`	`40`	`}`
`44`	`41`
`45`	`42`	`if (null === $sortableListener) {`
Original file line number	Diff line number	Diff line change
`@@ -62,12 +62,9 @@ protected function getTranslatableListener()`
`62`	`62`	`if ($listener instanceof TranslatableListener) {`
`63`	`63`	`$translatableListener = $listener;`
`64`	`64`
`65`		`- break;`
	`65`	`+ break 2;`
`66`	`66`	`}`
`67`	`67`	`}`
`68`		`- if ($translatableListener) {`
`69`		`- break;`
`70`		`- }`
`71`	`68`	`}`
`72`	`69`
`73`	`70`	`if (null === $translatableListener) {`
Original file line number	Diff line number	Diff line change
`@@ -36,12 +36,9 @@ public function __construct(DocumentManager $em, UnitOfWork $uow, ClassMetadata`
`36`	`36`	`if ($listener instanceof \Gedmo\Tree\TreeListener) {`
`37`	`37`	`$treeListener = $listener;`
`38`	`38`
`39`		`- break;`
	`39`	`+ break 2;`
`40`	`40`	`}`
`41`	`41`	`}`
`42`		`- if ($treeListener) {`
`43`		`- break;`
`44`		`- }`
`45`	`42`	`}`
`46`	`43`
`47`	`44`	`if (null === $treeListener) {`
Original file line number	Diff line number	Diff line change
`@@ -38,12 +38,9 @@ public function __construct(EntityManagerInterface $em, ClassMetadata $class)`
`38`	`38`	`if ($listener instanceof TreeListener) {`
`39`	`39`	`$treeListener = $listener;`
`40`	`40`
`41`		`- break;`
	`41`	`+ break 2;`
`42`	`42`	`}`
`43`	`43`	`}`
`44`		`- if ($treeListener) {`
`45`		`- break;`
`46`		`- }`
`47`	`44`	`}`
`48`	`45`
`49`	`46`	`if (null === $treeListener) {`