Skip to content

Commit 0daf14a

Browse files
committed
Fix false negative failing test
The test fails because the query is returning the two comments in descending ID order, when the test is expecting the opposite. This is only because of poor test enforcement / fixture data, and not related to actual library functionality.
1 parent c549b40 commit 0daf14a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tests/Gedmo/Translatable/TranslationQueryWalkerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -474,7 +474,7 @@ function shouldSelectSecondJoinedComponentTranslation()
474474
);
475475

476476
$dql = 'SELECT a, c FROM '.self::ARTICLE.' a';
477-
$dql .= ' LEFT JOIN a.comments c';
477+
$dql .= ' LEFT JOIN a.comments c ORDER BY c.id ASC';
478478
$q = $this->em->createQuery($dql);
479479
$q->setHint(Query::HINT_CUSTOM_OUTPUT_WALKER, self::TREE_WALKER_TRANSLATION);
480480

0 commit comments

Comments
 (0)