Skip to content

Commit 1838662

Browse files
authored
Merge branch 'v2.4.x' into patch-1
2 parents 675acf5 + fbfe3e2 commit 1838662

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

CHANGELOG.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,11 @@ a release.
2525

2626
### Translatable
2727
#### Fixed
28-
- Return `parent` instead of throwing Exception for Translatable (#2018)
28+
- Return default AST executor instead of throwing Exception in Walker (#2018)
29+
30+
### Tree
31+
#### Fixed
32+
- Remove hard-coded parent column name in repository prev/next sibling queries [#2020]
2933

3034
## [2.4.37] - 2019-03-17
3135
### Translatable

lib/Gedmo/Tree/Entity/Repository/NestedTreeRepository.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -426,7 +426,7 @@ public function getNextSiblingsQueryBuilder($node, $includeSelf = false)
426426
$qb->setParameter('pid', $wrappedParent->getIdentifier());
427427
} else if (isset($config['root']) && !$parent) {
428428
$qb->andWhere($qb->expr()->eq('node.'.$config['root'], ':root'));
429-
$qb->andWhere($qb->expr()->isNull('node.parent'));
429+
$qb->andWhere($qb->expr()->isNull('node.'.$config['parent']));
430430
$method = $config['rootIdentifierMethod'];
431431
$qb->setParameter('root', $node->$method());
432432
} else {
@@ -503,7 +503,7 @@ public function getPrevSiblingsQueryBuilder($node, $includeSelf = false)
503503
$qb->setParameter('pid', $wrappedParent->getIdentifier());
504504
} else if (isset($config['root']) && !$parent) {
505505
$qb->andWhere($qb->expr()->eq('node.'.$config['root'], ':root'));
506-
$qb->andWhere($qb->expr()->isNull('node.parent'));
506+
$qb->andWhere($qb->expr()->isNull('node.'.$config['parent']));
507507
$method = $config['rootIdentifierMethod'];
508508
$qb->setParameter('root', $node->$method());
509509
} else {

0 commit comments

Comments
 (0)