Fix PHPStan findings about iterable parameters

Author: phansys

phpstan-baseline.neon

@@ -255,11 +255,6 @@ parameters:
 			count: 3
 			path: src/Sluggable/Handler/TreeSlugHandler.php
 
-		-
-			message: "#^Part \\$option \\(array\\{string, mixed\\}\\) of encapsed string cannot be cast to string\\.$#"
-			count: 1
-			path: src/Sluggable/Mapping/Driver/Annotation.php
-
 		-
 			message: "#^Access to an undefined property Doctrine\\\\Persistence\\\\Mapping\\\\ClassMetadata\\:\\:\\$isMappedSuperclass\\.$#"
 			count: 1
@@ -505,6 +500,11 @@ parameters:
 			count: 1
 			path: src/Tree/TreeListener.php
 
+		-
+			message: "#^Method Gedmo\\\\Uploadable\\\\Event\\\\UploadableBaseEventArgs\\:\\:__construct\\(\\) has parameter \\$config with no value type specified in iterable type array\\.$#"
+			count: 2
+			path: src/Uploadable/Event/UploadableBaseEventArgs.php
+
 		-
 			message: "#^Method Gedmo\\\\Uploadable\\\\Event\\\\UploadableBaseEventArgs\\:\\:getExtensionConfiguration\\(\\) return type has no value type specified in iterable type array\\.$#"
 			count: 2

phpstan.neon.dist

@@ -19,8 +19,6 @@ parameters:
         - '#^Property Gedmo\\Tests\\.+\\Fixture\\[^:]+::\$\w+ is never written, only read\.$#'
         - '#^Property Gedmo\\Tests\\.+\\Fixture\\[^:]+::\$\w+ is never read, only written\.$#'
         - '#^Property Gedmo\\Tests\\.+\\Fixture\\[^:]+::\$\w+ is unused\.$#'
-        # @todo: Remove the following ignored error when the parameters are correctly declared.
-        - '#^Method Gedmo\\[^:]+::[^\(]+\(\) has parameter \$\w+ with no value type specified in iterable type array\.$#'
 
 rules:
     - PHPStan\Rules\Constants\MissingClassConstantTypehintRule

src/Loggable/Document/Repository/LogEntryRepository.php

@@ -106,7 +106,8 @@ public function revert($document, $version = 1)
     /**
      * Fills a documents versioned fields with data
      *
-     * @param object $document
+     * @param object               $document
+     * @param array<string, mixed> $data
      *
      * @return void
      *

src/Loggable/Mapping/Driver/Annotation.php

@@ -108,6 +108,8 @@ protected function isMappingValid(ClassMetadata $meta, $field)
     }
 
     /**
+     * @param array<string, mixed> $config
+     *
      * @return bool
      */
     protected function isClassAnnotationInValid(ClassMetadata $meta, array &$config)
@@ -117,6 +119,8 @@ protected function isClassAnnotationInValid(ClassMetadata $meta, array &$config)
 
     /**
      * Searches properties of embedded object for versioned fields
+     *
+     * @param array<string, mixed> $config
      */
     private function inspectEmbeddedForVersioned(string $field, array &$config, \Doctrine\ORM\Mapping\ClassMetadata $meta): void
     {

src/Loggable/Mapping/Driver/Xml.php

@@ -86,6 +86,8 @@ public function readExtendedMetadata($meta, array &$config)
 
     /**
      * Searches mappings on element for versioned fields
+     *
+     * @param array<string, mixed> $config
      */
     private function inspectElementForVersioned(\SimpleXMLElement $element, array &$config, ClassMetadata $meta): void
     {

src/Loggable/Mapping/Driver/Yaml.php

@@ -139,6 +139,10 @@ protected function _loadMappingFile($file)
         return \Symfony\Component\Yaml\Yaml::parse(file_get_contents($file));
     }
 
+    /**
+     * @param array<string, array<string, array<string, mixed>>> $mapping
+     * @param array<string, mixed>                               $config
+     */
     private function inspectEmbeddedForVersioned(string $field, array $mapping, array &$config): void
     {
         if (isset($mapping['fields'])) {

src/Mapping/Annotation/Blameable.php

@@ -34,6 +34,7 @@ final class Blameable implements GedmoAnnotation
     public $value;
 
     /**
+     * @param array<string, mixed> $data
      * @param string|string[]|null $field
      * @param mixed                $value
      */

src/Mapping/Annotation/IpTraceable.php

@@ -34,6 +34,7 @@ final class IpTraceable implements GedmoAnnotation
     public $value;
 
     /**
+     * @param array<string, mixed> $data
      * @param string|string[]|null $field
      * @param mixed                $value
      */

src/Mapping/Annotation/Loggable.php

@@ -37,6 +37,8 @@ final class Loggable implements GedmoAnnotation
     public $logEntryClass;
 
     /**
+     * @param array<string, mixed> $data
+     *
      * @phpstan-param class-string<T>|null $logEntryClass
      */
     public function __construct(array $data = [], ?string $logEntryClass = null)

src/Mapping/Annotation/Reference.php

@@ -51,6 +51,8 @@ abstract class Reference implements GedmoAnnotation
     public $inversedBy;
 
     /**
+     * @param array<string, mixed> $data
+     *
      * @phpstan-param class-string|null $class
      */
     public function __construct(