Fix some type hints

Author: phansys

src/Loggable/Document/MappedSuperclass/AbstractLogEntry.php

@@ -69,7 +69,7 @@ abstract class AbstractLogEntry
     protected $version;
 
     /**
-     * @var string
+     * @var array<string, mixed>|null
      *
      * @MongoODM\Field(type="hash", nullable=true)
      */
@@ -195,7 +195,7 @@ public function setLoggedAt()
     /**
      * Get data
      *
-     * @return array or null
+     * @return array<string, mixed>|null
      */
     public function getData()
     {
@@ -205,7 +205,7 @@ public function getData()
     /**
      * Set data
      *
-     * @param array $data
+     * @param array<string, mixed> $data
      */
     public function setData($data)
     {

src/Loggable/LoggableListener.php

@@ -267,7 +267,7 @@ protected function createLogEntry($action, $object, LoggableAdapter $ea)
 
         // Filter embedded documents
         if (isset($meta->isEmbeddedDocument) && $meta->isEmbeddedDocument) {
-            return;
+            return null;
         }
 
         if ($config = $this->getConfiguration($om, $meta->getName())) {

src/Mapping/Annotation/Tree.php

@@ -24,7 +24,7 @@ final class Tree extends Annotation
     /** @var string */
     public $type = 'nested';
 
-    /** @var string */
+    /** @var bool */
     public $activateLocking = false;
 
     /** @var int */

src/Mapping/Annotation/Uploadable.php

@@ -23,30 +23,48 @@
  */
 final class Uploadable extends Annotation
 {
-    /** @var bool */
+    /**
+     * @var bool
+     */
     public $allowOverwrite = false;
 
-    /** @var bool */
+    /**
+     * @var bool
+     */
     public $appendNumber = false;
 
-    /** @var string */
+    /**
+     * @var string
+     */
     public $path = '';
 
-    /** @var string */
+    /**
+     * @var string
+     */
     public $pathMethod = '';
 
-    /** @var string */
+    /**
+     * @var string
+     */
     public $callback = '';
 
-    /** @var string */
+    /**
+     * @var string
+     */
     public $filenameGenerator = Validator::FILENAME_GENERATOR_NONE;
 
-    /** @var float */
+    /**
+     * @var float
+     */
     public $maxSize = 0;
 
-    /** @var array */
+    /**
+     * @var string A list of comma separate values of allowed types, like "text/plain,text/css"
+     */
     public $allowedTypes = '';
 
-    /** @var array */
+    /**
+     * @var string A list of comma separate values of disallowed types, like "video/jpeg,text/html"
+     */
     public $disallowedTypes = '';
 }

src/Mapping/Driver/Xml.php

@@ -75,7 +75,7 @@ protected function _getBooleanAttribute(SimpleXmlElement $node, $attributeName)
      *
      * @param string $attributeName
      *
-     * @return string
+     * @return bool
      */
     protected function _isAttributeSet(SimpleXmlElement $node, $attributeName)
     {

src/Mapping/ExtensionMetadataFactory.php

@@ -83,7 +83,7 @@ public function __construct(ObjectManager $objectManager, $extensionNamespace, $
     public function getExtensionMetadata($meta)
     {
         if ($meta->isMappedSuperclass) {
-            return; // ignore mappedSuperclasses for now
+            return []; // ignore mappedSuperclasses for now
         }
         $config = [];
         $cmf = $this->objectManager->getMetadataFactory();

src/Mapping/MappedEventSubscriber.php

@@ -55,14 +55,14 @@ abstract class MappedEventSubscriber implements EventSubscriber
      * ExtensionMetadataFactory used to read the extension
      * metadata through the extension drivers
      *
-     * @var ExtensionMetadataFactory
+     * @var array<int, ExtensionMetadataFactory>
      */
     private $extensionMetadataFactory = [];
 
     /**
      * List of event adapters used for this listener
      *
-     * @var array
+     * @var array<string, AdapterInterface>
      */
     private $adapters = [];
 
@@ -181,9 +181,9 @@ public function loadMetadataForObjectClass(ObjectManager $objectManager, $metada
             $config = $factory->getExtensionMetadata($metadata);
         } catch (\ReflectionException $e) {
             // entity\document generator is running
-            $config = false; // will not store a cached version, to remap later
+            $config = []; // will not store a cached version, to remap later
         }
-        if ($config) {
+        if ([] !== $config) {
             self::$configurations[$this->name][$metadata->getName()] = $config;
         }
     }

src/References/LazyCollection.php

@@ -39,7 +39,7 @@ public function clear()
     {
         $this->initialize();
 
-        return $this->results->clear();
+        $this->results->clear();
     }
 
     public function contains($element)
@@ -179,7 +179,7 @@ public function set($key, $value)
     {
         $this->initialize();
 
-        return $this->results->set($key, $value);
+        $this->results->set($key, $value);
     }
 
     public function slice($offset, $length = null)
@@ -214,14 +214,14 @@ public function offsetSet($offset, $value)
     {
         $this->initialize();
 
-        return $this->results->offsetSet($offset, $value);
+        $this->results->offsetSet($offset, $value);
     }
 
     public function offsetUnset($offset)
     {
         $this->initialize();
 
-        return $this->results->offsetUnset($offset);
+        $this->results->offsetUnset($offset);
     }
 
     public function getIterator()

src/References/Mapping/Event/Adapter/ORM.php

@@ -62,6 +62,8 @@ public function getIdentifier($om, $object, $single = true)
 
             return [$meta->getIdentifier()[0] => $id];
         }
+
+        return null;
     }
 
     /**

src/References/Mapping/Event/ReferencesAdapter.php

@@ -50,7 +50,7 @@ public function getSingleReference($om, $class, $identifier);
      * @param object        $object
      * @param bool          $single
      *
-     * @return array|string|int array or single identifier
+     * @return array|string|int|null array or single identifier
      */
     public function extractIdentifier($om, $object, $single = true);
 }