[tree] Test for property existence

nclavaud · nclavaud · commit 594749f2f579 · 2018-04-19T12:38:21.000+02:00
ref #1910 Instead of testing the property value, test its existence.
diff --git a/lib/Gedmo/Tree/Strategy/ORM/Nested.php b/lib/Gedmo/Tree/Strategy/ORM/Nested.php
@@ -125,7 +125,7 @@ public function processScheduledInsertion($em, $node, AdapterInterface $ea)
         if (isset($config['level'])) {
             $meta->getReflectionProperty($config['level'])->setValue($node, 0);
         }
-        if (isset($config['root']) && !$meta->hasAssociation($config['root']) && !$config['rootIdentifierMethod']) {
+        if (isset($config['root']) && !$meta->hasAssociation($config['root']) && !isset($config['rootIdentifierMethod'])) {
             $meta->getReflectionProperty($config['root'])->setValue($node, 0);
         } else if (isset($config['rootIdentifierMethod']) && is_null($meta->getReflectionProperty($config['root'])->getValue($node))) {
             $meta->getReflectionProperty($config['root'])->setValue($node, 0);

Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,7 @@ public function processScheduledInsertion($em, $node, AdapterInterface $ea)`
`125`	`125`	`if (isset($config['level'])) {`
`126`	`126`	`$meta->getReflectionProperty($config['level'])->setValue($node, 0);`
`127`	`127`	`}`
`128`		`- if (isset($config['root']) && !$meta->hasAssociation($config['root']) && !$config['rootIdentifierMethod']) {`
	`128`	`+ if (isset($config['root']) && !$meta->hasAssociation($config['root']) && !isset($config['rootIdentifierMethod'])) {`
`129`	`129`	`$meta->getReflectionProperty($config['root'])->setValue($node, 0);`
`130`	`130`	`} else if (isset($config['rootIdentifierMethod']) && is_null($meta->getReflectionProperty($config['root'])->getValue($node))) {`
`131`	`131`	`$meta->getReflectionProperty($config['root'])->setValue($node, 0);`