Skip to content

Commit 5e2cc07

Browse files
authored
Merge pull request #1800 from romain-pierre/fix-quote
Fixes deprecated usages of the quote methods
2 parents f1c30b5 + 8ab7dda commit 5e2cc07

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

lib/Gedmo/Translatable/Query/TreeWalker/TranslationWalker.php

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
namespace Gedmo\Translatable\Query\TreeWalker;
44

5+
use Doctrine\ORM\Mapping\ClassMetadata;
56
use Gedmo\Translatable\Mapping\Event\Adapter\ORM as TranslatableEventAdapter;
67
use Gedmo\Translatable\TranslatableListener;
78
use Doctrine\DBAL\Types\Type;
@@ -296,41 +297,43 @@ private function prepareTranslatedComponents()
296297
$em = $this->getEntityManager();
297298
$ea = new TranslatableEventAdapter();
298299
$ea->setEntityManager($em);
300+
$quoteStrategy = $em->getConfiguration()->getQuoteStrategy();
299301
$joinStrategy = $q->getHint(TranslatableListener::HINT_INNER_JOIN) ? 'INNER' : 'LEFT';
300302

301303
foreach ($this->translatedComponents as $dqlAlias => $comp) {
304+
/** @var ClassMetadata $meta */
302305
$meta = $comp['metadata'];
303306
$config = $this->listener->getConfiguration($em, $meta->name);
304307
$transClass = $this->listener->getTranslationClass($ea, $meta->name);
305308
$transMeta = $em->getClassMetadata($transClass);
306-
$transTable = $em->getConfiguration()->getQuoteStrategy()->getTableName($transMeta, $this->platform);
309+
$transTable = $quoteStrategy->getTableName($transMeta, $this->platform);
307310
foreach ($config['fields'] as $field) {
308311
$compTblAlias = $this->walkIdentificationVariable($dqlAlias, $field);
309312
$tblAlias = $this->getSQLTableAlias('trans'.$compTblAlias.$field);
310313
$sql = " {$joinStrategy} JOIN ".$transTable.' '.$tblAlias;
311-
$sql .= ' ON '.$tblAlias.'.'.$transMeta->getQuotedColumnName('locale', $this->platform)
314+
$sql .= ' ON '.$tblAlias.'.'.$quoteStrategy->getColumnName('locale', $transMeta, $this->platform)
312315
.' = '.$this->conn->quote($locale);
313-
$sql .= ' AND '.$tblAlias.'.'.$transMeta->getQuotedColumnName('field', $this->platform)
316+
$sql .= ' AND '.$tblAlias.'.'.$quoteStrategy->getColumnName('field', $transMeta, $this->platform)
314317
.' = '.$this->conn->quote($field);
315318
$identifier = $meta->getSingleIdentifierFieldName();
316-
$idColName = $meta->getQuotedColumnName($identifier, $this->platform);
319+
$idColName = $quoteStrategy->getColumnName($identifier, $meta, $this->platform);
317320
if ($ea->usesPersonalTranslation($transClass)) {
318321
$sql .= ' AND '.$tblAlias.'.'.$transMeta->getSingleAssociationJoinColumnName('object')
319322
.' = '.$compTblAlias.'.'.$idColName;
320323
} else {
321-
$sql .= ' AND '.$tblAlias.'.'.$transMeta->getQuotedColumnName('objectClass', $this->platform)
324+
$sql .= ' AND '.$tblAlias.'.'.$quoteStrategy->getColumnName('objectClass', $transMeta, $this->platform)
322325
.' = '.$this->conn->quote($config['useObjectClass']);
323326

324327
$mappingFK = $transMeta->getFieldMapping('foreignKey');
325328
$mappingPK = $meta->getFieldMapping($identifier);
326329
$fkColName = $this->getCastedForeignKey($compTblAlias.'.'.$idColName, $mappingFK['type'], $mappingPK['type']);
327-
$sql .= ' AND '.$tblAlias.'.'.$transMeta->getQuotedColumnName('foreignKey', $this->platform)
330+
$sql .= ' AND '.$tblAlias.'.'.$quoteStrategy->getColumnName('foreignKey', $transMeta, $this->platform)
328331
.' = '.$fkColName;
329332
}
330333
isset($this->components[$dqlAlias]) ? $this->components[$dqlAlias] .= $sql : $this->components[$dqlAlias] = $sql;
331334

332-
$originalField = $compTblAlias.'.'.$meta->getQuotedColumnName($field, $this->platform);
333-
$substituteField = $tblAlias.'.'.$transMeta->getQuotedColumnName('content', $this->platform);
335+
$originalField = $compTblAlias.'.'.$quoteStrategy->getColumnName($field, $meta, $this->platform);
336+
$substituteField = $tblAlias.'.'.$quoteStrategy->getColumnName('content', $transMeta, $this->platform);
334337

335338
// Treat translation as original field type
336339
$fieldMapping = $meta->getFieldMapping($field);

0 commit comments

Comments
 (0)