Deprecate AbstractWrapper::clear() and WrapperInterface::populate() methods

Author: franmomu

CHANGELOG.md

@@ -51,6 +51,8 @@ a release.
 - `Gedmo\Tool\Logging\DBAL\QueryAnalizer` class without replacement.
 - Using YAML mapping is deprecated, you SHOULD migrate to attributes, annotations or XML.
 - `Gedmo\Mapping\Event\AdapterInterface::__call()` method.
+- `Gedmo\Tool\Wrapper\AbstractWrapper::clear()` method.
+- `Gedmo\Tool\Wrapper\WrapperInterface::populate()` method.
 
 ### Changed
 - In order to use a custom cache for storing configuration of an extension, the user has to call `setCacheItemPool()`

src/Sluggable/SluggableListener.php

@@ -17,7 +17,6 @@
 use Gedmo\Sluggable\Handler\SlugHandlerWithUniqueCallbackInterface;
 use Gedmo\Sluggable\Mapping\Event\SluggableAdapter;
 use Gedmo\Sluggable\Util\Urlizer;
-use Gedmo\Tool\Wrapper\AbstractWrapper;
 
 /**
  * The SluggableListener handles the generation of slugs
@@ -241,8 +240,6 @@ public function onFlush(EventArgs $args)
         }
 
         $this->manageFiltersAfterGeneration($om);
-
-        AbstractWrapper::clear();
     }
 
     protected function getNamespace()

src/Tool/Wrapper/AbstractWrapper.php

@@ -45,13 +45,6 @@ abstract class AbstractWrapper implements WrapperInterface
      */
     protected $om;
 
-    /**
-     * List of wrapped object references
-     *
-     * @var array
-     */
-    private static $wrappedObjectReferences;
-
     /**
      * Wrap object factory method
      *
@@ -78,7 +71,10 @@ public static function wrap($object, ObjectManager $om)
      */
     public static function clear()
     {
-        self::$wrappedObjectReferences = [];
+        @trigger_error(sprintf(
+            'Using "%s()" method is deprecated since gedmo/doctrine-extensions 3.x and will be removed in version 4.0.',
+            __METHOD__
+        ), E_USER_DEPRECATED);
     }
 
     public function getObject()
@@ -93,6 +89,11 @@ public function getMetadata()
 
     public function populate(array $data)
     {
+        @trigger_error(sprintf(
+            'Using "%s()" method is deprecated since gedmo/doctrine-extensions 3.x and will be removed in version 4.0.',
+            __METHOD__
+        ), E_USER_DEPRECATED);
+
         foreach ($data as $field => $value) {
             $this->setPropertyValue($field, $value);
         }

src/Tool/WrapperInterface.php

@@ -45,6 +45,8 @@ public function getPropertyValue($property);
     public function setPropertyValue($property, $value);
 
     /**
+     * @deprecated since gedmo/doctrine-extensions 3.x and to be removed in version 4.0.
+     *
      * Populates the wrapped object with the given property values.
      *
      * @return $this

tests/Gedmo/Wrapper/EntityWrapperTest.php

@@ -88,7 +88,7 @@ public function testSomeFunctions(): void
         $test = new Article();
         $wrapped = new EntityWrapper($test, $this->em);
 
-        $wrapped->populate(['title' => 'test']);
+        $test->setTitle('test');
         static::assertSame('test', $wrapped->getPropertyValue('title'));
 
         static::assertFalse($wrapped->hasValidIdentifier());

tests/Gedmo/Wrapper/MongoDocumentWrapperTest.php

@@ -86,7 +86,7 @@ public function testSomeFunctions(): void
         $test = new Article();
         $wrapped = new MongoDocumentWrapper($test, $this->dm);
 
-        $wrapped->populate(['title' => 'test']);
+        $test->setTitle('test');
         static::assertSame('test', $wrapped->getPropertyValue('title'));
 
         static::assertFalse($wrapped->hasValidIdentifier());