Use class-string type

Author: franmomu

src/Loggable/LoggableListener.php

@@ -187,8 +187,10 @@ public function onFlush(EventArgs $eventArgs)
      * Get the LogEntry class
      *
      * @param string $class
+     * @phpstan-param class-string $class
      *
      * @return string
+     * @phpstan-return class-string
      */
     protected function getLogEntryClass(LoggableAdapter $ea, $class)
     {

src/Mapping/MappedEventSubscriber.php

@@ -45,6 +45,7 @@ abstract class MappedEventSubscriber implements EventSubscriber
      * other listener configuration
      *
      * @var array
+     * @phpstan-var array<string, array<class-string, array<string, mixed>>>
      */
     protected static $configurations = [];
 
@@ -98,8 +99,9 @@ public function __construct()
      * if cache driver is present it scans it also
      *
      * @param string $class
+     * @phpstan-param class-string $class
      *
-     * @return array
+     * @return array<string, mixed>
      */
     public function getConfiguration(ObjectManager $objectManager, $class)
     {

src/Translatable/Document/Repository/TranslationRepository.php

@@ -162,6 +162,7 @@ public function findTranslations($document)
      * @param string $field
      * @param string $value
      * @param string $class
+     * @phpstan-param class-string $class
      *
      * @return object|null instance of $class or null if not found
      */

src/Translatable/Mapping/Event/Adapter/ORM.php

@@ -229,6 +229,7 @@ public function setTranslationValue($object, $field, $value)
      *
      * @param mixed  $key       foreign key value
      * @param string $className translation class name
+     * @phpstan-param class-string $className translation class name
      *
      * @return int|string transformed foreign key
      */

src/Translatable/TranslatableListener.php

@@ -214,8 +214,10 @@ public function loadClassMetadata(EventArgs $eventArgs)
      * for the object $class
      *
      * @param string $class
+     * @phpstan-param class-string $class
      *
      * @return string
+     * @phpstan-return class-string
      */
     public function getTranslationClass(TranslatableAdapter $ea, $class)
     {

src/Tree/Strategy/ORM/Nested.php

@@ -529,6 +529,8 @@ public function updateNode(EntityManagerInterface $em, $node, $parent, $position
      * @param string $class
      * @param int    $rootId
      *
+     * @phpstan-param class-string $class
+     *
      * @return int
      */
     public function max(EntityManagerInterface $em, $class, $rootId = 0)
@@ -555,11 +557,10 @@ public function max(EntityManagerInterface $em, $class, $rootId = 0)
      * @param string     $class
      * @param int        $first
      * @param int        $delta
-     * @param string     $class
-     * @param int        $first
-     * @param int        $delta
      * @param int|string $root
      *
+     * @phpstan-param class-string $class
+     *
      * @return void
      */
     public function shiftRL(EntityManagerInterface $em, $class, $first, $delta, $root = null)
@@ -634,6 +635,8 @@ public function shiftRL(EntityManagerInterface $em, $class, $first, $delta, $roo
      * @param int|string $destRoot
      * @param int        $levelDelta
      *
+     * @phpstan-param class-string $class
+     *
      * @return void
      */
     public function shiftRangeRL(EntityManagerInterface $em, $class, $first, $last, $delta, $root = null, $destRoot = null, $levelDelta = null)

tests/Gedmo/Tool/BaseTestCaseOM.php

@@ -122,7 +122,7 @@ protected function getDefaultMockSqliteEntityManager(array $fixtures, MappingDri
         $config = $this->getMockORMConfig($mappingDriver);
         $em = EntityManager::create($conn, $config, $this->getEventManager());
 
-        $schema = array_map(static function ($class) use ($em) {
+        $schema = array_map(static function (string $class) use ($em) {
             return $em->getClassMetadata($class);
         }, $fixtures);
 

tests/Gedmo/Tree/ClosureTreeRepositoryTest.php

@@ -262,6 +262,9 @@ public function testChangeChildrenIndex(): void
 
     // Utility Methods
 
+    /**
+     * @phpstan-param class-string $class
+     */
     protected function buildTreeTests(string $class): void
     {
         $repo = $this->em->getRepository($class);

tests/Gedmo/Tree/MaterializedPathORMRepositoryTest.php

@@ -366,13 +366,9 @@ public function testChangeChildrenIndex(): void
     }
 
     /**
-     * @phpstan-param class-string<TCategory>|null $class
-     *
-     * @return MPCategory|TCategory
-     *
-     * @template TCategory of object
+     * @phpstan-param class-string|null $class
      */
-    public function createCategory(?string $class = null)
+    public function createCategory(?string $class = null): object
     {
         if (!$class) {
             $class = self::CATEGORY;
@@ -389,6 +385,9 @@ protected function getUsedEntityFixtures(): array
         ];
     }
 
+    /**
+     * @phpstan-param class-string|null $class
+     */
     private function populate(string $class = null): void
     {
         $root = $this->createCategory($class);