fixes PHP-CS and PHPStan reportings

Signed-off-by: Stefan Gehrig <[email protected]>

Author: sgehrig

tests/Gedmo/Tree/Fixture/Issue2582/OU.php

@@ -1,5 +1,12 @@
 <?php
 
+/*
+ * This file is part of the Doctrine Behavioral Extensions package.
+ * (c) Gediminas Morkevicius <[email protected]> http://www.gediminasm.org
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 namespace Gedmo\Tests\Tree\Fixture\Issue2582;
 
 use Doctrine\Common\Collections\ArrayCollection;
@@ -73,16 +80,18 @@ class OU
     /**
      * @ORM\OneToMany(targetEntity="\Gedmo\Tests\Tree\Fixture\Issue2582\OU", mappedBy="parent")
      * @ORM\OrderBy({"left" = "ASC"})
+     *
+     * @var Collection<int, self>
      */
     #[ORM\OneToMany(targetEntity: self::class, mappedBy: 'parent')]
     #[ORM\OrderBy(['left' => 'ASC'])]
     private Collection $children;
 
     public function __construct(string $id, ?self $parent = null)
     {
-        $this->id       = $id;
+        $this->id = $id;
         $this->children = new ArrayCollection();
-        $this->parent   = $parent;
+        $this->parent = $parent;
         if ($parent) {
             $parent->children->add($this);
         }
@@ -93,7 +102,7 @@ public function getId(): string
         return $this->id;
     }
 
-    public function getParent(): ?OU
+    public function getParent(): ?self
     {
         return $this->parent;
     }
@@ -113,6 +122,9 @@ public function getRight(): int
         return $this->right;
     }
 
+    /**
+     * @return Collection<int, self>
+     */
     public function getChildren(): Collection
     {
         return $this->children;

tests/Gedmo/Tree/Issue/Issue2582Test.php

@@ -32,9 +32,9 @@ protected function setUp(): void
 
     public function testInsertTwoRootsInOneFlush(): void
     {
-        $ou1  = new OU('00000000-0000-0000-0000-000000000001', null);
+        $ou1 = new OU('00000000-0000-0000-0000-000000000001', null);
         $ou11 = new OU('00000000-0000-0000-0000-000000000011', $ou1);
-        $ou2  = new OU('00000000-0000-0000-0000-000000000002', null);
+        $ou2 = new OU('00000000-0000-0000-0000-000000000002', null);
         $ou21 = new OU('00000000-0000-0000-0000-000000000021', $ou2);
 
 
@@ -53,7 +53,7 @@ public function testInsertTwoRootsInOneFlush(): void
             ['00000000-0000-0000-0000-000000000021', '00000000-0000-0000-0000-000000000002', 6, 1, 7],
         ];
         foreach ($this->fetchAllOUs() as $i => $a) {
-            self::assertSame(
+            static::assertSame(
                 $expected[$i],
                 [
                     $a->getId(),
@@ -68,9 +68,9 @@ public function testInsertTwoRootsInOneFlush(): void
 
     public function testInsertTwoRootsInOneFlushRootsFirst(): void
     {
-        $ou1  = new OU('00000000-0000-0000-0000-000000000001', null);
+        $ou1 = new OU('00000000-0000-0000-0000-000000000001', null);
         $ou11 = new OU('00000000-0000-0000-0000-000000000011', $ou1);
-        $ou2  = new OU('00000000-0000-0000-0000-000000000002', null);
+        $ou2 = new OU('00000000-0000-0000-0000-000000000002', null);
         $ou21 = new OU('00000000-0000-0000-0000-000000000021', $ou2);
 
 
@@ -89,7 +89,7 @@ public function testInsertTwoRootsInOneFlushRootsFirst(): void
             ['00000000-0000-0000-0000-000000000021', '00000000-0000-0000-0000-000000000002', 6, 1, 7],
         ];
         foreach ($this->fetchAllOUs() as $i => $a) {
-            self::assertSame(
+            static::assertSame(
                 $expected[$i],
                 [
                     $a->getId(),
@@ -104,9 +104,9 @@ public function testInsertTwoRootsInOneFlushRootsFirst(): void
 
     public function testInsertTwoRootsInTwoFlushes(): void
     {
-        $ou1  = new OU('00000000-0000-0000-0000-000000000001', null);
+        $ou1 = new OU('00000000-0000-0000-0000-000000000001', null);
         $ou11 = new OU('00000000-0000-0000-0000-000000000011', $ou1);
-        $ou2  = new OU('00000000-0000-0000-0000-000000000002', null);
+        $ou2 = new OU('00000000-0000-0000-0000-000000000002', null);
         $ou21 = new OU('00000000-0000-0000-0000-000000000021', $ou2);
 
 
@@ -126,7 +126,7 @@ public function testInsertTwoRootsInTwoFlushes(): void
             ['00000000-0000-0000-0000-000000000021', '00000000-0000-0000-0000-000000000002', 6, 1, 7],
         ];
         foreach ($this->fetchAllOUs() as $i => $a) {
-            self::assertSame(
+            static::assertSame(
                 $expected[$i],
                 [
                     $a->getId(),
@@ -139,6 +139,14 @@ public function testInsertTwoRootsInTwoFlushes(): void
         }
     }
 
+    protected function getUsedEntityFixtures(): array
+    {
+        return [OU::class];
+    }
+
+    /**
+     * @return list<OU>
+     */
     private function fetchAllOUs(): array
     {
         $categoryRepo = $this->em->getRepository(OU::class);
@@ -148,9 +156,4 @@ private function fetchAllOUs(): array
             ->getQuery()
             ->getResult();
     }
-
-    protected function getUsedEntityFixtures(): array
-    {
-        return [OU::class];
-    }
 }