Add type declarations in private functions

Author: phansys

src/Loggable/Document/Repository/LogEntryRepository.php

@@ -140,10 +140,8 @@ protected function fillDocument($document, array $data)
      * Get the currently used LoggableListener
      *
      * @throws \Gedmo\Exception\RuntimeException if listener is not found
-     *
-     * @return LoggableListener
      */
-    private function getLoggableListener()
+    private function getLoggableListener(): LoggableListener
     {
         if (null === $this->listener) {
             foreach ($this->dm->getEventManager()->getListeners() as $event => $listeners) {

src/Loggable/Entity/Repository/LogEntryRepository.php

@@ -141,10 +141,8 @@ protected function mapValue(ClassMetadata $objectMeta, $field, &$value)
      * Get the currently used LoggableListener
      *
      * @throws \Gedmo\Exception\RuntimeException if listener is not found
-     *
-     * @return LoggableListener
      */
-    private function getLoggableListener()
+    private function getLoggableListener(): LoggableListener
     {
         if (null === $this->listener) {
             foreach ($this->_em->getEventManager()->getListeners() as $event => $listeners) {

src/Loggable/Mapping/Driver/Annotation.php

@@ -120,10 +120,8 @@ protected function isClassAnnotationInValid(ClassMetadata $meta, array &$config)
 
     /**
      * Searches properties of embedded object for versioned fields
-     *
-     * @param string $field
      */
-    private function inspectEmbeddedForVersioned($field, array &$config, \Doctrine\ORM\Mapping\ClassMetadata $meta)
+    private function inspectEmbeddedForVersioned(string $field, array &$config, \Doctrine\ORM\Mapping\ClassMetadata $meta): void
     {
         $class = new \ReflectionClass($meta->embeddedClasses[$field]['class']);
 

src/Loggable/Mapping/Driver/Xml.php

@@ -9,6 +9,7 @@
 
 namespace Gedmo\Loggable\Mapping\Driver;
 
+use Doctrine\Persistence\Mapping\ClassMetadata;
 use Gedmo\Exception\InvalidMappingException;
 use Gedmo\Mapping\Driver\Xml as BaseXml;
 
@@ -85,10 +86,8 @@ public function readExtendedMetadata($meta, array &$config)
 
     /**
      * Searches mappings on element for versioned fields
-     *
-     * @param object $meta
      */
-    private function inspectElementForVersioned(\SimpleXMLElement $element, array &$config, $meta)
+    private function inspectElementForVersioned(\SimpleXMLElement $element, array &$config, ClassMetadata $meta): void
     {
         foreach ($element as $mapping) {
             $mappingDoctrine = $mapping;

src/Loggable/Mapping/Driver/Yaml.php

@@ -140,10 +140,7 @@ protected function _loadMappingFile($file)
         return \Symfony\Component\Yaml\Yaml::parse(file_get_contents($file));
     }
 
-    /**
-     * @param string $field
-     */
-    private function inspectEmbeddedForVersioned($field, array $mapping, array &$config)
+    private function inspectEmbeddedForVersioned(string $field, array $mapping, array &$config): void
     {
         if (isset($mapping['fields'])) {
             foreach ($mapping['fields'] as $property => $fieldMapping) {

src/Mapping/MappedEventSubscriber.php

@@ -74,7 +74,7 @@ abstract class MappedEventSubscriber implements EventSubscriber
     private $annotationReader;
 
     /**
-     * @var \Doctrine\Common\Annotations\AnnotationReader
+     * @var AnnotationReader
      */
     private static $defaultAnnotationReader;
 
@@ -245,10 +245,8 @@ protected function setFieldValue(AdapterInterface $adapter, $object, $field, $ol
 
     /**
      * Create default annotation reader for extensions
-     *
-     * @return \Doctrine\Common\Annotations\AnnotationReader
      */
-    private function getDefaultAnnotationReader()
+    private function getDefaultAnnotationReader(): Reader
     {
         if (null === self::$defaultAnnotationReader) {
             AnnotationRegistry::registerAutoloadNamespace('Gedmo\\Mapping\\Annotation', __DIR__.'/../../');

src/References/LazyCollection.php

@@ -238,7 +238,7 @@ public function count()
         return $this->results->count();
     }
 
-    private function initialize()
+    private function initialize(): void
     {
         if (null === $this->results) {
             $this->results = call_user_func($this->callback);

src/References/Mapping/Event/Adapter/ODM.php

@@ -96,7 +96,7 @@ public function extractIdentifier($om, $object, $single = true)
     /**
      * Override so we don't get an exception. We want to allow this.
      */
-    private function throwIfNotEntityManager(EntityManagerInterface $em)
+    private function throwIfNotEntityManager(EntityManagerInterface $em): void
     {
     }
 }

src/References/Mapping/Event/Adapter/ORM.php

@@ -110,7 +110,7 @@ public function extractIdentifier($om, $object, $single = true)
     /**
      * Override so we don't get an exception. We want to allow this.
      */
-    private function throwIfNotDocumentManager($dm)
+    private function throwIfNotDocumentManager($dm): void
     {
         if (!($dm instanceof MongoDocumentManager) && !($dm instanceof PhpcrDocumentManager)) {
             throw new InvalidArgumentException(sprintf('Expected a %s or %s instance but got "%s"', MongoDocumentManager::class, 'Doctrine\ODM\PHPCR\DocumentManager', is_object($dm) ? get_class($dm) : gettype($dm)));

src/References/ReferencesListener.php

@@ -183,7 +183,7 @@ protected function getNamespace()
         return __NAMESPACE__;
     }
 
-    private function updateReferences(EventArgs $eventArgs)
+    private function updateReferences(EventArgs $eventArgs): void
     {
         $ea = $this->getEventAdapter($eventArgs);
         $om = $ea->getObjectManager();