Fix some phpstan findings in tests

Author: franmomu

tests/Gedmo/SoftDeleteable/HardRelationTest.php

@@ -20,17 +20,12 @@
 
 final class HardRelationTest extends BaseTestCaseORM
 {
-    /**
-     * @var SoftDeleteableListener
-     */
-    private $softDeleteableListener;
-
     protected function setUp(): void
     {
         parent::setUp();
 
         $evm = new EventManager();
-        $evm->addEventSubscriber($this->softDeleteableListener = new SoftDeleteableListener());
+        $evm->addEventSubscriber(new SoftDeleteableListener());
         $this->getDefaultMockSqliteEntityManager($evm);
         $this->em->getConfiguration()->addFilter('softdelete', SoftDeleteableFilter::class);
         $this->em->getFilters()->enable('softdelete');

tests/Gedmo/Tool/BaseTestCaseORM.php

@@ -40,7 +40,7 @@
 abstract class BaseTestCaseORM extends TestCase
 {
     /**
-     * @var EntityManager
+     * @var EntityManager|null
      */
     protected $em;
 
@@ -94,7 +94,7 @@ protected function getDefaultMockSqliteEntityManager(EventManager $evm = null, C
      */
     protected function startQueryLog(): void
     {
-        if (!$this->em || !$this->em->getConnection()->getDatabasePlatform()) {
+        if (null === $this->em || null === $this->em->getConnection()->getDatabasePlatform()) {
             throw new \RuntimeException('EntityManager and database platform must be initialized');
         }
         $this->queryAnalyzer = new QueryAnalyzer($this->em->getConnection()->getDatabasePlatform());

tests/Gedmo/Translatable/Fixture/Type/Custom.php

@@ -43,7 +43,7 @@ public function convertToPHPValue($value, AbstractPlatform $platform)
         $value = (is_resource($value)) ? stream_get_contents($value) : $value;
         $val = unserialize($value);
         if (false === $val && 'b:0;' !== $value) {
-            new \Exception('Conversion failed');
+            throw new \Exception('Conversion failed');
         }
 
         return $val;

tests/Gedmo/Translatable/Issue/Issue173Test.php

@@ -25,7 +25,7 @@
  * These are tests for translatable behavior
  *
  * @author Gediminas Morkevicius <[email protected]>
- * @contributor Oscar Balladares [email protected] https://github.com/oscarballadares
+ * @author Oscar Balladares [email protected] https://github.com/oscarballadares
  */
 final class Issue173Test extends BaseTestCaseORM
 {

tests/Gedmo/Tree/MaterializedPathORMRepositoryTest.php

@@ -38,11 +38,6 @@ final class MaterializedPathORMRepositoryTest extends BaseTestCaseORM
      */
     private $listener;
 
-    /**
-     * @var array
-     */
-    private $config = [];
-
     protected function setUp(): void
     {
         parent::setUp();
@@ -55,7 +50,7 @@ protected function setUp(): void
         $this->getDefaultMockSqliteEntityManager($evm);
 
         $meta = $this->em->getClassMetadata(self::CATEGORY);
-        $this->config = $this->listener->getConfiguration($this->em, $meta->getName());
+        $this->listener->getConfiguration($this->em, $meta->getName());
         $this->populate();
 
         $this->repo = $this->em->getRepository(self::CATEGORY);

tests/Gedmo/Uploadable/UploadableEntityTest.php

@@ -92,18 +92,6 @@ final class UploadableEntityTest extends BaseTestCaseORM
     /** @var string */
     private $destinationTestFile;
 
-    /** @var string */
-    private $destinationTestFile2;
-
-    /** @var string */
-    private $destinationTestFile3;
-
-    /** @var string */
-    private $destinationTestFileWithoutExt;
-
-    /** @var string */
-    private $destinationTestFileWithSpaces;
-
     /** @var false|string */
     private $testFilename;
 
@@ -143,10 +131,6 @@ protected function setUp(): void
         $this->testFileWithSpaces = TESTS_PATH.'/data/test with spaces.txt';
         $this->destinationTestDir = TESTS_TEMP_DIR.'/uploadable';
         $this->destinationTestFile = $this->destinationTestDir.'/test.txt';
-        $this->destinationTestFile2 = $this->destinationTestDir.'/test2.txt';
-        $this->destinationTestFile3 = $this->destinationTestDir.'/test_3.txt';
-        $this->destinationTestFileWithoutExt = $this->destinationTestDir.'/test4';
-        $this->destinationTestFileWithSpaces = $this->destinationTestDir.'/test with spaces';
         $this->testFilename = substr($this->testFile, strrpos($this->testFile, '/') + 1);
         $this->testFilename2 = substr($this->testFile2, strrpos($this->testFile2, '/') + 1);
         $this->testFilename3 = substr($this->testFile3, strrpos($this->testFile3, '/') + 1);