Merge pull request #1710 from dmaicher/fix_deprecations

dmaicher · web-flow · commit 96fe0fff1f4a · 2023-10-22T14:02:50.000+02:00
fix doWarmUp $buildDir deprecation
diff --git a/CacheWarmer/DoctrineMetadataCacheWarmer.php b/CacheWarmer/DoctrineMetadataCacheWarmer.php
@@ -31,8 +31,7 @@ public function isOptional(): bool
         return false;
     }
 
-    /** @param string $cacheDir */
-    protected function doWarmUp($cacheDir, ArrayAdapter $arrayAdapter): bool
+    protected function doWarmUp(string $cacheDir, ArrayAdapter $arrayAdapter, ?string $buildDir = null): bool
     {
         // cache already warmed up, no needs to do it again
         if (is_file($this->phpArrayFile)) {

Original file line number	Diff line number	Diff line change
`@@ -31,8 +31,7 @@ public function isOptional(): bool`
`31`	`31`	`return false;`
`32`	`32`	`}`
`33`	`33`
`34`		`- /** @param string $cacheDir */`
`35`		`- protected function doWarmUp($cacheDir, ArrayAdapter $arrayAdapter): bool`
	`34`	`+ protected function doWarmUp(string $cacheDir, ArrayAdapter $arrayAdapter, ?string $buildDir = null): bool`
`36`	`35`	`{`
`37`	`36`	`// cache already warmed up, no needs to do it again`
`38`	`37`	`if (is_file($this->phpArrayFile)) {`