Class "xxx" is not a valid entity or mapped super class

[renjinsk]

Bug Report

Q	A
Version	2.18.1
Previous Version if the bug is a regression	2.18.0

Summary

If a class has an annotation @MappedSuperclass Symfony throws the following error
Class "xxx\yyy\zzz" is not a valid entity or mapped super class.

Current behavior

Throws exception Class "XXX" is not a valid entity or mapped super class

Expected behavior

Not throw the error.

How to reproduce

Create a class and annotate it with @MappedSuperclass like the following

<?php

namespace xxx\yyy\Entity;

use Doctrine\ORM\Mapping as ORM;

/**
 * @package xxx\yyy\Entity
 * @ORM\MappedSuperclass(repositoryClass="xxx\yyy\Repository\SomeClass")
 */
class SomeClass
{

}

I think the change in this PR #2115 has broken the detection of MappedSuperclass annotations.

[ostrolucky]

cc @jtattevin

[stof]

AFAICT, our detection logic has never detected annotation as driver automatically based on the presence of the MappedSuperclass (except maybe at the time annotation was the fallback type before adding support for attributes). And so a bundle containing only mapped superclasses might have been detected wrongly.

It worked for your own use case by luck because of the @package annotation being wrong detected as an Entity annotation due to the namespace you have (which is exactly the root cause of the bug that got fixed, when the mapping was not using annotations).

We might need to add support for MappedSuperclass in the detection logic (similar to how Embeddable is supported)

[jtattevin]

Since the change was still fresh I've made #2171 that should fix that by searching for MappedSuperclass like it's done for Embeddable.

[renjinsk]

Since the change was still fresh I've made #2171 that should fix that by searching for MappedSuperclass like it's done for Embeddable.

Cheers! Thanks for the fast resolution of the issue!