Fully deprecate controller resolver auto mapping #1804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobvandevijver
force-pushed
the
mapped-route-parameters
branch
from
41a8c3d to
f666de9
Compare
ostrolucky
approved these changes
Jun 23, 2024
ostrolucky
requested changes
Jun 23, 2024
There was a problem hiding this comment.
Ah sorry it took a while to review, but tests need to be adjusted
Remaining self deprecation notices (100)
100x: Since doctrine/doctrine-bundle 2.13: Enabling the controller resolver automapping feature has been deprecated. Symfony Mapped Route Parameters should be used as replacement.
6x in DoctrineExtensionTest::testCacheConfiguration from Doctrine\Bundle\DoctrineBundle\Tests\DependencyInjection
3x in DoctrineExtensionTest::testAutomapping from Doctrine\Bundle\DoctrineBundle\Tests\DependencyInjection
2x in DoctrineExtensionTest::testDependencyInjectionConfigurationDefaults from Doctrine\Bundle\DoctrineBundle\Tests\DependencyInjection
2x in DoctrineExtensionTest::testSingleEntityManagerWithEmptyConfiguration from Doctrine\Bundle\DoctrineBundle\Tests\DependencyInjection
2x in DoctrineExtensionTest::testControllerResolver from Doctrine\Bundle\DoctrineBundle\Tests\DependencyInjection
...
|
@ostrolucky No worries. I added the message to the edit: ah, you're quick, great 👍 |
|
@bobvandevijver hi! I just created the 3.0.x branch, and I see you created an |
bobvandevijver
added a commit
to bobvandevijver/DoctrineBundle
that referenced
this pull request
Sep 2, 2025
Remove controller resolver auto mapping configuration as discussed in doctrine#1804.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony 7.1 has deprecated the use of the controller resolver auto mapper functionality in favour of the new mapped route parameters, which have the benefit of being explicit and concise (see symfony/symfony#54455, symfony/symfony#54720 and https://symfony.com/blog/new-in-symfony-7-1-mapped-route-parameters for the discussion and more details).
Note that we already deprecated not setting a value with #1762 to be able to change its default to false with 3.0, but now I propose to fully remove this configuration option with 3.0 instead, with both not setting and true being deprecated. Depending on when 3.0 would be available, removed the option could be postponed to 4.0 if desired.
/cc @nicolas-grekas - symfony/recipes#1316