Skip to content

Commit 18f7ed8

Browse files
authored
Merge pull request #595 from greg0ire/internalize
Make classes internal
2 parents 5d8fb55 + 5ea607a commit 18f7ed8

File tree

7 files changed

+10
-3
lines changed

7 files changed

+10
-3
lines changed

UPGRADE.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22

33
## 4.0.0
44

5-
## BC break: final classes
5+
## BC break: final, internal classes
66

7-
Some classes have been marked as `final` because they are not supposed to be
8-
extended. Consider using composition instead of inheritance.
7+
Some classes have been marked as `final` and `@internal` because they are not
8+
supposed to be extended or even referenced outside of the bundle.
99

1010
### BC break: type declarations
1111

src/Collector/MigrationsCollector.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
use function count;
1717
use function get_class;
1818

19+
/** @internal */
1920
final class MigrationsCollector extends DataCollector
2021
{
2122
public function __construct(

src/Collector/MigrationsFlattener.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
use function array_map;
1515

16+
/** @internal */
1617
final class MigrationsFlattener
1718
{
1819
/**

src/DependencyInjection/CompilerPass/ConfigureDependencyFactoryPass.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
use function is_string;
2020
use function sprintf;
2121

22+
/** @internal */
2223
final class ConfigureDependencyFactoryPass implements CompilerPassInterface
2324
{
2425
public function process(ContainerBuilder $container): void

src/DependencyInjection/Configuration.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
use function strtoupper;
2020
use function substr;
2121

22+
/** @internal */
2223
final class Configuration implements ConfigurationInterface
2324
{
2425
public function getConfigTreeBuilder(): TreeBuilder

src/DependencyInjection/DoctrineMigrationsExtension.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
use function strlen;
2929
use function substr;
3030

31+
/** @internal */
3132
final class DoctrineMigrationsExtension extends Extension
3233
{
3334
/**

src/EventListener/SchemaFilterListener.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
* Acts as a schema filter that hides the migration metadata table except
1414
* when the execution context is that of command inside the migrations
1515
* namespace.
16+
*
17+
* @internal
1618
*/
1719
final class SchemaFilterListener
1820
{

0 commit comments

Comments
 (0)